unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [RFC, experimental] save_{excursion,restriction}
Date: Wed, 25 Jul 2012 19:44:34 -0400	[thread overview]
Message-ID: <jwvobn3cstu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <500FBEB2.7050302@yandex.ru> (Dmitry Antipov's message of "Wed, 25 Jul 2012 13:38:58 +0400")

>> I think you'll be better off making it into a standard Lisp_Object such
>> as pseudovector or a Lisp_Misc.  The fact that they're only used on the
>> specpdl and hence managed via xmalloc+xfree shouldn't make them
>> that special.

> OK. The only question is: should `excursion' field of struct buffer
> be special, like `undo_list', or handled as usual? This patch assumes
> first scenario, but it's not a problem to follow the second one.

If the excursion is made into a Lisp_Object (as a pseudovector of
lisp_misc), then you don't need to have an `excursions' field in
`struct buffer', save_excursion_save can just return the excursion
object (i.e. the PVEC_EXCURSION in your code).


        Stefan



  reply	other threads:[~2012-07-25 23:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 17:07 [RFC, experimental] save_{excursion,restriction} Dmitry Antipov
2012-07-23 23:45 ` Stefan Monnier
2012-07-24  5:16   ` Dmitry Antipov
2012-07-24  9:37     ` Stefan Monnier
2012-07-24 11:28       ` Dmitry Antipov
2012-07-24 22:05         ` Stefan Monnier
2012-07-25  9:38           ` Dmitry Antipov
2012-07-25 23:44             ` Stefan Monnier [this message]
2012-07-26  5:14               ` Dmitry Antipov
2012-07-26 23:24                 ` Stefan Monnier
2012-07-24  6:31   ` Ivan Andrus
2012-07-24  9:14     ` Stefan Monnier
2012-07-27  3:51 ` Chong Yidong
2012-07-27  8:00   ` Dmitry Antipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvobn3cstu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).