unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCHv4 0/4] Add `remember-notes' function
Date: Sun, 30 Jun 2013 18:29:35 -0400	[thread overview]
Message-ID: <jwvoban2rol.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <cover.1372076606.git.mina86@mina86.com> (Michal Nazarewicz's message of "Mon, 24 Jun 2013 14:35:44 +0200")

Installed with some changes:
- The setter of remember-data-file uses set-visited-file-name and
  find-buffer-visiting.
- Don't add toggle-remember-notes (not sure why such a command would be
  useful/needed, and it doesn't follow the "remember-" prefix).
- Remove code duplication in remember-append-to-file.
- Add remember-notes--kill-buffer-query only to the affected buffer.
- Don't add remember-notes--buffer.
- Use a new remember-notes-mode minor mode.
- Use nil as special value for remember-notes-initial-major-mode
  (renamed from initial-remember-notes-major-mode to obey the
  "remember-" prefix).
- remember-notes-bury-on-kill renamed from bury-remember-notes-on-kill.
- remember-notes-save-and-bury-buffer, moved and renamed from window.el
  (maybe we should have such a global command, but then I'd like to see
  other uses for it and it should be moved to simple,el, not window.el).


        Stefan



  parent reply	other threads:[~2013-06-30 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 12:35 [PATCHv4 0/4] Add `remember-notes' function Michal Nazarewicz
2013-06-24 12:35 ` [PATCHv4 1/4] `kill-buffer' runs query functions before checking buffer modification Michal Nazarewicz
2013-06-24 17:05   ` martin rudalics
2013-06-24 18:31     ` Michal Nazarewicz
2013-06-24 20:57       ` martin rudalics
2013-06-24 22:35         ` Michal Nazarewicz
2013-06-25  6:47           ` martin rudalics
2013-06-24 12:35 ` [PATCHv4 2/4] `remember-append-to-file' appending to buffer bug fix Michal Nazarewicz
2013-06-24 12:35 ` [PATCHv4 3/4] Add `remember-notes' function to store notes across Emacs restarts Michal Nazarewicz
2013-06-24 12:35 ` [PATCHv4 4/4] Simplify conditional expression in `find-file-noselect' Michal Nazarewicz
2013-06-30 22:29 ` Stefan Monnier [this message]
2013-07-04 12:56   ` [PATCHv4 0/4] Add `remember-notes' function Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvoban2rol.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).