unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: trunk r113550: Add support for lexical variables to the debugger's `e' command.
       [not found] <E1V2cca-00041c-4C@vcs.savannah.gnu.org>
@ 2013-07-26 17:35 ` Glenn Morris
  2013-07-26 18:42   ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2013-07-26 17:35 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier wrote:

>   * lisp/subr.el (internal--called-interactively-p--get-frame): Remove.

This breaks nadvice.el. The coverage job on hydra would have flagged
this if we didn't already have a failing testsuite.

http://hydra.nixos.org/build/5581041/log/raw

Test advice-test-called-interactively-p condition:
    (void-function internal--called-interactively-p--get-frame)
   FAILED    5/342  advice-test-called-interactively-p

>   (called-interactively-p):

Missing description?



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: trunk r113550: Add support for lexical variables to the debugger's `e' command.
  2013-07-26 17:35 ` trunk r113550: Add support for lexical variables to the debugger's `e' command Glenn Morris
@ 2013-07-26 18:42   ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2013-07-26 18:42 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

>> * lisp/subr.el (internal--called-interactively-p--get-frame): Remove.
> This breaks nadvice.el.

Duh!  Should be fixed now.

>> (called-interactively-p):
> Missing description?

No, it's shared with the next entry.


        Stefan






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-26 18:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1V2cca-00041c-4C@vcs.savannah.gnu.org>
2013-07-26 17:35 ` trunk r113550: Add support for lexical variables to the debugger's `e' command Glenn Morris
2013-07-26 18:42   ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).