From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Mon, 02 Dec 2013 22:06:28 -0500 Message-ID: References: <871u1zes89.fsf@yandex.ru> <5298AA77.4060009@yandex.ru> <52991737.9000904@yandex.ru> <529A0C08.8010809@yandex.ru> <529BF309.4010109@yandex.ru> <529D1168.9090102@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386040003 17562 80.91.229.3 (3 Dec 2013 03:06:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Dec 2013 03:06:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 03 04:06:48 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VngK0-0002N2-6L for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2013 04:06:48 +0100 Original-Received: from localhost ([::1]:39916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VngJz-0002fb-L6 for ged-emacs-devel@m.gmane.org; Mon, 02 Dec 2013 22:06:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VngJp-0002ec-VL for emacs-devel@gnu.org; Mon, 02 Dec 2013 22:06:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VngJi-0006Ff-Fm for emacs-devel@gnu.org; Mon, 02 Dec 2013 22:06:37 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VngJi-0006FU-D6 for emacs-devel@gnu.org; Mon, 02 Dec 2013 22:06:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpZzs/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtjR+BD4JcA4hhnBmBXoJqK4FR X-IPAS-Result: Av4EABK/CFFFpZzs/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtjR+BD4JcA4hhnBmBXoJqK4FR X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40972640" Original-Received: from 69-165-156-236.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.236]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Dec 2013 22:06:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 1542B603FC; Mon, 2 Dec 2013 22:06:28 -0500 (EST) In-Reply-To: <529D1168.9090102@yandex.ru> (Dmitry Gutov's message of "Tue, 03 Dec 2013 01:02:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166025 Archived-At: >> I think it's good to try and make the *VC-Log* (and the *mail*) buffers >> behave similarly to file buffers in this respect. > I don't see this problem with mail. When I'm in a message-mode buffer (say, > writing a reply from Gnus), and I press C-x k RET, Emacs warns me that the > buffer is modified and asks for confirmation. I didn't mean to say that there's a problem with mail. Nor that we should prompt for *VC-Log*. Just that it would be an acceptable behavior. > See the small patch at the bottom for log-edit. It seems to work, but I fear > it may complicate some scenarios where buffers are killed automatically. As written earlier, I think it's OK to kill without prompting and simply stash the buffer's contents in the log-comment history. Stefan