From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest -- electric-pair-mode change Date: Sat, 05 Apr 2014 11:29:39 -0400 Message-ID: References: <87d2h0ujls.fsf_-_@kitaj.lan> <87sipujhq2.fsf@kitaj.lan> <87mwg1jz43.fsf@kitaj.lan> <87d2gwk6xf.fsf@kitaj.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396711810 32158 80.91.229.3 (5 Apr 2014 15:30:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2014 15:30:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: joaotavora@gmail.com (=?windows-1252?B?Sm/jbyBU4XZvcmE=?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 05 17:30:02 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWSXg-0007bR-Di for ged-emacs-devel@m.gmane.org; Sat, 05 Apr 2014 17:30:00 +0200 Original-Received: from localhost ([::1]:55009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWSXf-000535-Ov for ged-emacs-devel@m.gmane.org; Sat, 05 Apr 2014 11:29:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWSXW-00052P-K1 for emacs-devel@gnu.org; Sat, 05 Apr 2014 11:29:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWSXP-000887-2M for emacs-devel@gnu.org; Sat, 05 Apr 2014 11:29:50 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:59294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWSXO-000882-SY for emacs-devel@gnu.org; Sat, 05 Apr 2014 11:29:42 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s35FTd1E002151; Sat, 5 Apr 2014 11:29:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9E92860125; Sat, 5 Apr 2014 11:29:39 -0400 (EDT) In-Reply-To: <87d2gwk6xf.fsf@kitaj.lan> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sat, 05 Apr 2014 00:31:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4903=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4903> : inlines <692> : streams <1152651> : uri <1721257> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171315 Archived-At: > Yes, that was a bad mistake. But in comments, we have to > parse-partial-sexp from the comment block's start, not just from (nth 8 > (syntax-ppss)), otherwise won't work in multi-line comment > blocks. Yes, but that's covered by the (forward-comment (- (point))) that comes right after, IIUC. > So I commited this to trunk, with two new tests for this behaviour in > ruby line-comments and c block-style comments. Thanks. I think this can go into emacs-24. Stefan