From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Mon, 02 Feb 2015 12:58:52 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422899958 24883 80.91.229.3 (2 Feb 2015 17:59:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2015 17:59:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 18:59:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YILHE-00070R-SW for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 18:59:13 +0100 Original-Received: from localhost ([::1]:55879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YILHE-0005pH-8Z for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 12:59:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YILGz-0005pC-BK for emacs-devel@gnu.org; Mon, 02 Feb 2015 12:58:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YILGw-0006kF-3e for emacs-devel@gnu.org; Mon, 02 Feb 2015 12:58:57 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:21909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YILGv-0006kB-W8 for emacs-devel@gnu.org; Mon, 02 Feb 2015 12:58:54 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Am8PAOwQflRsoX+8/2dsb2JhbABbgweBK4I1hVrFHQQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCzQSFA0LDSQTiCsDCQnQUQ2FewEBAQcBAQEBHo44gVURAVAHhEgFiwGFOolMgyuNMIJDggqBeIQZITCBDYE6AQEB X-IPAS-Result: Am8PAOwQflRsoX+8/2dsb2JhbABbgweBK4I1hVrFHQQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCzQSFA0LDSQTiCsDCQnQUQ2FewEBAQcBAQEBHo44gVURAVAHhEgFiwGFOolMgyuNMIJDggqBeIQZITCBDYE6AQEB X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="109467712" Original-Received: from 108-161-127-188.dsl.teksavvy.com (HELO ceviche.home) ([108.161.127.188]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 02 Feb 2015 12:58:53 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id D91C866100; Mon, 2 Feb 2015 12:58:52 -0500 (EST) In-Reply-To: (Jackson Hamilton's message of "Sun, 1 Feb 2015 23:49:48 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182276 Archived-At: > which included 247 commits. I am not sure if these should be squashed, but > based on the commit log it seems like this subtree approach is how other > people are managing their externally-maintained packages, so I assume it is > okay to add the whole history. Indeed, it's OK to keep the history. > On top of that, I added 2 patches so that I could test ELPA locally. I was > able to install my package via a "local-elpa" as described in the README. > The patches for that are attached in this email. I think the hydra-test.el has been fixed by someone else in the mean time. As for your change: > +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan Andersson I think this change is incorrect. IIUC this is johan.rejeep@gmail.com we're talking bout, and he signed the copyright assignment forms, so the line in ert-async.el should say "Copyright (C) 2014 Free Software Foundation, Inc" (at which point you won't need any change to copyright_exceptions). Stefan