From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jackson Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel@gnu.org
Subject: Re: Requesting review before pushing patch to ELPA
Date: Mon, 02 Feb 2015 12:58:52 -0500 [thread overview]
Message-ID: <jwvoapcfbia.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAGiE8Az6kAQTNuhrZO_dGB1O9hOMqeSbxMOH0bG+RDLPUY0z=A@mail.gmail.com> (Jackson Hamilton's message of "Sun, 1 Feb 2015 23:49:48 -0800")
> which included 247 commits. I am not sure if these should be squashed, but
> based on the commit log it seems like this subtree approach is how other
> people are managing their externally-maintained packages, so I assume it is
> okay to add the whole history.
Indeed, it's OK to keep the history.
> On top of that, I added 2 patches so that I could test ELPA locally. I was
> able to install my package via a "local-elpa" as described in the README.
> The patches for that are attached in this email.
I think the hydra-test.el has been fixed by someone else in the
mean time. As for your change:
> +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan Andersson
I think this change is incorrect. IIUC this is johan.rejeep@gmail.com
we're talking bout, and he signed the copyright assignment forms, so
the line in ert-async.el should say "Copyright (C) 2014 Free Software
Foundation, Inc" (at which point you won't need any change to copyright_exceptions).
Stefan
next prev parent reply other threads:[~2015-02-02 17:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 7:49 Requesting review before pushing patch to ELPA Jackson Hamilton
2015-02-02 17:58 ` Stefan Monnier [this message]
2015-02-03 5:57 ` Jackson Hamilton
2015-02-03 12:13 ` Artur Malabarba
2015-02-04 9:24 ` Jackson Hamilton
2015-02-04 11:15 ` Artur Malabarba
2015-02-04 11:16 ` Artur Malabarba
2015-02-03 17:51 ` Stefan Monnier
2015-02-04 9:32 ` Jackson Hamilton
2015-02-04 15:14 ` Stefan Monnier
2015-02-04 19:46 ` Jackson Hamilton
2015-02-04 19:48 ` Dmitry Gutov
2015-02-04 21:58 ` Stefan Monnier
2015-02-05 8:05 ` Jackson Hamilton
2015-02-05 14:10 ` Stefan Monnier
2015-02-05 18:17 ` Jackson Hamilton
2015-02-05 18:39 ` Matthew Carter
2015-02-05 18:48 ` Jackson Hamilton
2015-02-05 20:22 ` Stefan Monnier
2015-02-04 15:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoapcfbia.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).