From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Daniel Colascione <dancol@dancol.org>
Subject: Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior
Date: Mon, 04 May 2015 18:16:30 -0400 [thread overview]
Message-ID: <jwvoam0c872.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YpLPp-0000IV-4c@vcs.savannah.gnu.org> (Daniel Colascione's message of "Mon, 04 May 2015 18:48:29 +0000")
> + (let ((mark (mark-marker)))
> + (and mark (marker-position mark) (copy-marker mark)))
Here you consider that (mark-marker) can return nil.
> +(defun save-mark-and-excursion--restore (saved-mark-info)
> + (let ((saved-mark (car saved-mark-info))
> + (omark (marker-position (mark-marker)))
But here you assume it's always a marker.
> + (setf nmark (marker-position saved-mark))
^^^^
Old habits die hard.
> + (let ((cur-mark-active mark-active))
> + (setf mark-active saved-mark-active)
> + ;; If mark is active now, and either was not active or was at a
> + ;; different place, run the activate hook.
> + (if saved-mark-active
> + (unless (eq omark nmark)
> + (run-hooks 'activate-mark-hook))
IIUC activate-mark-hook should also be run when (eq omark nmark) but
cur-mark-active was nil.
Stefan
next parent reply other threads:[~2015-05-04 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150504184829.1108.13525@vcs.savannah.gnu.org>
[not found] ` <E1YpLPp-0000IV-4c@vcs.savannah.gnu.org>
2015-05-04 22:16 ` Stefan Monnier [this message]
2015-05-04 22:37 ` [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior Daniel Colascione
2015-05-05 17:48 ` Stefan Monnier
2015-05-04 23:02 ` Nicolas Petton
2015-05-04 23:04 ` Daniel Colascione
2015-05-05 17:50 ` Stefan Monnier
2015-05-05 18:04 ` Daniel Colascione
2015-05-05 19:00 ` Stefan Monnier
2015-05-05 18:31 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoam0c872.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).