From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay Date: Tue, 06 Oct 2015 12:15:35 -0400 Message-ID: References: <20150930193450.11644.62040@vcs.savannah.gnu.org> <831tdd75i3.fsf@gnu.org> <83eghd5ff2.fsf@gnu.org> <83vbap3qxb.fsf@gnu.org> <83r3lc4du9.fsf@gnu.org> <83mvvz0xkh.fsf@gnu.org> <83bncdz20p.fsf@gnu.org> <56137EFA.8050403@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444148981 31504 80.91.229.3 (6 Oct 2015 16:29:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 16:29:41 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 06 18:29:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from eggs.gnu.org ([208.118.235.92]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjV7F-0007ur-7t for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2015 18:29:25 +0200 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjV7C-0008Il-Rp for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2015 12:29:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Original-Received: from lists.gnu.org ([208.118.235.17]:47110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjUyJ-0002Hp-6d for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2015 12:20:11 -0400 Original-Received: from localhost ([::1]:52537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjUyJ-0007da-1A for ged-emacs-devel@m.gmane.org; Tue, 06 Oct 2015 12:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjUtw-0006X4-VY for emacs-devel@gnu.org; Tue, 06 Oct 2015 12:15:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjUtw-00060t-2l for emacs-devel@gnu.org; Tue, 06 Oct 2015 12:15:40 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjUts-0005z8-Gf; Tue, 06 Oct 2015 12:15:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV/3aQs2tcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBAwEnLyMQCzQSFBgNJC6ICQjPIwEBAQEGAQEBAR6LOoUFB4QtBbUEI4FmVYFZIoJ4AQEB X-IPAS-Result: A0CVDQA731xV/3aQs2tcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBAwEnLyMQCzQSFBgNJC6ICQjPIwEBAQEGAQEBAR6LOoUFB4QtBbUEI4FmVYFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="167725655" Original-Received: from 107-179-144-118.cpe.teksavvy.com (HELO pastel.home) ([107.179.144.118]) by ironport2-out.teksavvy.com with ESMTP; 06 Oct 2015 12:15:35 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 373236283A; Tue, 6 Oct 2015 12:15:35 -0400 (EDT) In-Reply-To: <56137EFA.8050403@gmx.at> (martin rudalics's message of "Tue, 06 Oct 2015 09:57:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 Xref: news.gmane.org gmane.emacs.devel:191017 Archived-At: >> I think for fset_frame either way would work about as well: it should be >> relatively rarely used anyway. OTOH for bset_redisplay, I expect that the >> cost of finding all the buffer's windows would be clearly too costly. > Nothing should prevent us from replacing window_count with a list of the > windows showing the buffer. Sure, but I suspect calls to bset_redisplay can be much more numerous, so I think it's much cheaper to have redisplay check b->text->redisplay once per redisplay, than to have bset_redisplay loop through the corresponding windows every time (even if this looping can indeed be made more efficient if needed). In any case, these choices don't seem particularly important, and changing them wouldn't make much difference to the code. So feel free to try alternatives if you want, but personally, I think it'd be a waste of time since the current solution is very cheap. Stefan