unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay
Date: Tue, 06 Oct 2015 12:15:35 -0400	[thread overview]
Message-ID: <jwvoagcdlot.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <56137EFA.8050403@gmx.at> (martin rudalics's message of "Tue, 06 Oct 2015 09:57:46 +0200")

>> I think for fset_frame either way would work about as well: it should be
>> relatively rarely used anyway.  OTOH for bset_redisplay, I expect that the
>> cost of finding all the buffer's windows would be clearly too costly.
> Nothing should prevent us from replacing window_count with a list of the
> windows showing the buffer.

Sure, but I suspect calls to bset_redisplay can be much more numerous,
so I think it's much cheaper to have redisplay check b->text->redisplay
once per redisplay, than to have bset_redisplay loop through the
corresponding windows every time (even if this looping can indeed be
made more efficient if needed).

In any case, these choices don't seem particularly important, and
changing them wouldn't make much difference to the code.  So feel free
to try alternatives if you want, but personally, I think it'd be a waste
of time since the current solution is very cheap.


        Stefan



      reply	other threads:[~2015-10-06 16:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150930193450.11644.62040@vcs.savannah.gnu.org>
     [not found] ` <E1ZhN9O-00032Q-5G@vcs.savannah.gnu.org>
2015-10-02 12:44   ` [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay Stefan Monnier
2015-10-02 13:40     ` Eli Zaretskii
2015-10-02 15:46       ` Stefan Monnier
2015-10-02 17:49         ` Eli Zaretskii
2015-10-02 20:55           ` Stefan Monnier
2015-10-02 21:24             ` Eli Zaretskii
2015-10-03  1:05               ` Stefan Monnier
2015-10-03  7:21                 ` Eli Zaretskii
2015-10-04  2:33                   ` Stefan Monnier
2015-10-04  9:53                     ` Eli Zaretskii
2015-10-05 15:50                       ` Stefan Monnier
2015-10-05 16:57                         ` Eli Zaretskii
2015-10-05 22:46                           ` Stefan Monnier
2015-10-06  1:19                             ` Stefan Monnier
2015-10-06  7:57                             ` martin rudalics
2015-10-06 16:15                               ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvoagcdlot.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).