From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member Date: Mon, 12 Oct 2015 21:07:00 -0400 Message-ID: References: <20151012170324.17966.77@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444698446 31606 80.91.229.3 (13 Oct 2015 01:07:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 01:07:26 +0000 (UTC) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 13 03:07:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zlo3h-0005cq-C3 for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 03:07:17 +0200 Original-Received: from localhost ([::1]:59816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlo3g-0001LD-5N for ged-emacs-devel@m.gmane.org; Mon, 12 Oct 2015 21:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlo3V-0001L8-G9 for emacs-devel@gnu.org; Mon, 12 Oct 2015 21:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlo3U-0007ZW-Ow for emacs-devel@gnu.org; Mon, 12 Oct 2015 21:07:05 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlo3Q-0007Xy-UK; Mon, 12 Oct 2015 21:07:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0ArEwA731xV/xWhxEVcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNiFsIzyMBAQEBBgEBAQEeizqFBQcWhBcBBLM/gUUjhBQigngBAQE X-IPAS-Result: A0ArEwA731xV/xWhxEVcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNiFsIzyMBAQEBBgEBAQEeizqFBQcWhBcBBLM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="169360711" Original-Received: from 69-196-161-21.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.161.21]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Oct 2015 21:07:00 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 10FF5AE668; Mon, 12 Oct 2015 21:07:00 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Mon, 12 Oct 2015 17:03:24 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191417 Archived-At: > Attempt to avoid crashes in plist-member > * src/fns.c (Fplist_member): Don't call QUIT between a CONSP test > and a call to XCDR. (Bug#21655) I have no objection to the patch itself, but I must say that I wonder how it can avoid crashes. IOW why would calling QUIT between a CONSP test and a call to XCDR be dangerous? Stefan