From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] master 19e09cf: Ensure redisplay after evaluation
Date: Sat, 07 Nov 2015 18:40:30 -0500 [thread overview]
Message-ID: <jwvoaf5mljs.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1ZumbR-00081I-Hj@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 06 Nov 2015 19:23:13 +0000")
> @@ -1240,6 +1240,7 @@ set_internal (Lisp_Object symbol, Lisp_Object newval, Lisp_Object where,
> return;
> }
> + maybe_set_redisplay (symbol);
> sym = XSYMBOL (symbol);
> start:
In dynamic-binding code, this is a chunk of code that's executed *very*
often, so I expect your change could have a measurable performance impact
(e.g. on Gnus code).
The write-barrier discussed in the past moved this check to within the
SYMBOL_CONSTANT_P test. More specifically, it turned the
SYMBOL_CONSTANT_P boolean into a field with 3 different values,
depending on whether a write can:
- go through at full-speed
- goes through a watcher function (or call it a "barrier")
- is not allowed at all
This way, assignments to most variables is unaffected.
Stefan
next parent reply other threads:[~2015-11-07 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151106192313.30794.29154@vcs.savannah.gnu.org>
[not found] ` <E1ZumbR-00081I-Hj@vcs.savannah.gnu.org>
2015-11-07 23:40 ` Stefan Monnier [this message]
2015-11-08 16:12 ` [Emacs-diffs] master 19e09cf: Ensure redisplay after evaluation Eli Zaretskii
2015-11-08 22:24 ` Stefan Monnier
2015-11-09 21:48 ` Richard Stallman
2015-11-10 1:16 ` Stefan Monnier
2015-11-10 18:18 ` Richard Stallman
2015-11-10 19:34 ` Stefan Monnier
2015-11-09 19:06 ` John Wiegley
2015-11-09 19:17 ` Eli Zaretskii
2015-11-09 21:57 ` John Wiegley
2015-11-13 0:31 ` Noam Postavsky
2015-11-13 8:06 ` Eli Zaretskii
2015-11-13 13:58 ` Stefan Monnier
2015-11-13 16:36 ` Noam Postavsky
2015-11-13 18:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoaf5mljs.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).