From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 872014e: Prevent accidental deletion of .git Date: Mon, 09 Nov 2015 00:03:34 -0500 Message-ID: References: <20151109013124.17711.29422@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447045439 21089 80.91.229.3 (9 Nov 2015 05:03:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Nov 2015 05:03:59 +0000 (UTC) Cc: "=?windows-1252?Q?Fabi=E1n?= E. Gallina" , emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 09 06:03:46 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvecL-0001LF-JT for ged-emacs-devel@m.gmane.org; Mon, 09 Nov 2015 06:03:45 +0100 Original-Received: from localhost ([::1]:50194 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvecL-00077Z-Bj for ged-emacs-devel@m.gmane.org; Mon, 09 Nov 2015 00:03:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvecG-000748-JS for emacs-devel@gnu.org; Mon, 09 Nov 2015 00:03:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvecD-0000Sb-EQ for emacs-devel@gnu.org; Mon, 09 Nov 2015 00:03:40 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvecD-0000SW-Aj; Mon, 09 Nov 2015 00:03:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AtEwA731xV/6sLr7hcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSQtiAoIzyMBAQEHAQEBAR6LOoQgZQeELQWMMKcPgUUjhBYggTSBRAEBAQ X-IPAS-Result: A0AtEwA731xV/6sLr7hcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSQtiAoIzyMBAQEHAQEBAR6LOoQgZQeELQWMMKcPgUUjhBYggTSBRAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="177566794" Original-Received: from 184-175-11-171.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([184.175.11.171]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Nov 2015 00:03:37 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6D4FFAE250; Mon, 9 Nov 2015 00:03:34 -0500 (EST) In-Reply-To: (Thomas Fitzsimmons's message of "Sun, 08 Nov 2015 23:49:27 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193687 Archived-At: >> Once we change the handling of :core in elpa/admin/archive-contents.el >> so that it sets up symlinks rather than performing copies, we should at >> least be able to make the deletion less dangerous, e.g. by only deleting >> symlinks and empty directories (so even if the deletion was erroneous, >> no actual file contents was destroyed along the way). >> Fabi=E1n, any news on this? > Arthur pointed out in another thread that this code is at least > partially there already (I haven't heard from Fabi=E1n about its status). Right, Fabian installed its code already, but I found out at that point that the way it works (i.e copying files from emacs.git) is problematic in various ways: it should instead setup symlinks. > The attached patch seems to work Yes, it kinda works but it suffers from various warts (e.g. "make externals; make" will always recompile all the :core packages). > with a locally-generated archive, but it introduces the first external > to make use of :core. Should I push it and see what happens? No, we should change to code to use symlinks instead of file-copies first (and at the same time change it as I suggested, i.e. to only delete symlinks and empty directories). Stefan