From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] RFC: eldoc-documentation-functions hook Date: Sun, 17 Jul 2016 14:52:17 -0400 Message-ID: References: <20160612061229.GA6463@holos.localdomain> <838tyahoim.fsf@gnu.org> <20160612182453.GA12034@holos.localdomain> <20160613211735.GA5969@holos.localdomain> <20160617210849.GA3775@holos.localdomain> <20160707033019.GA22360@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468781597 24850 80.91.229.3 (17 Jul 2016 18:53:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Jul 2016 18:53:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 17 20:53:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOrBd-00059d-Lq for ged-emacs-devel@m.gmane.org; Sun, 17 Jul 2016 20:53:09 +0200 Original-Received: from localhost ([::1]:42728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOrBd-00038m-49 for ged-emacs-devel@m.gmane.org; Sun, 17 Jul 2016 14:53:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOrB2-00038h-L7 for emacs-devel@gnu.org; Sun, 17 Jul 2016 14:52:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOrAy-0001DX-Ek for emacs-devel@gnu.org; Sun, 17 Jul 2016 14:52:31 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:45946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOrAy-0001DS-7g for emacs-devel@gnu.org; Sun, 17 Jul 2016 14:52:28 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bOrAt-0004WX-Jr for emacs-devel@gnu.org; Sun, 17 Jul 2016 20:52:23 +0200 Original-Received: from 69-165-156-121.dsl.teksavvy.com ([69.165.156.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 17 Jul 2016 20:52:23 +0200 Original-Received: from monnier by 69-165-156-121.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 17 Jul 2016 20:52:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-156-121.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:sGhS1Dm82r7qpfNZPcjd68svtDE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205787 Archived-At: >>> Applied with some wording changes as 5811404 >> I don't think we have reached any consensus. > The problem is not just that it introduces a gratuitous incompatiblity, > but that it's a regression since you can't use things like :around nor > choose precedence (as in add-function's `depth') with add-hook. I know of 3 motivations to replace foo-function with foo-functions: - habit and consistency: Emacs has used add-hook for many many years, so having to start using add-function is inconvenient. That is true and I don't have a good argument against this, except that foo-function also have existed for many years so the fact that you can't use add-hook on them is not really new. What is new is that you can use add-function on them. - C-h v foo-function RET gives a value that's unreadable. That is true and we should improve it. I don't think there's anything really hard about doing so, so it's a transient motivation and it'd be better to fix `C-h v' than to circumvent the problem by using foo-functions. - (add-function :before (local 'foo-function) #'toto) is more verbose than (add-hook 'foo-functions #'toto nil t). That's true. But the difference is not very large. We could try and reduce it, but I'm not sure it's worth the trouble, especially since the fact that you can choose between (say) :before and :around is one of the main benefits of foo-function over foo-functions. -- Stefan