From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: The current state of the comment-cache branch Date: Sat, 21 Jan 2017 23:28:08 -0500 Message-ID: References: <20161227175500.GD2324@acm.fritz.box> <83y3z0ukth.fsf@gnu.org> <871swsf1es.fsf@thinkpad.rath.org> <83pokcugit.fsf@gnu.org> <87y3yzehc2.fsf@thinkpad.rath.org> <83d1gbv1rt.fsf@gnu.org> <87wpei7jye.fsf@thinkpad.rath.org> <83shp6tyqr.fsf@gnu.org> <20161229194454.GB3387@acm.fritz.box> <2ddc3f91-acf9-803a-f99d-9ccb63f748b9@online.de> <03ceef3b-7adb-0f0b-d8d8-e1f2e6c0a04a@online.de> <38e90e33-aaae-d8e6-ec2c-bfc239d5e1cd@online.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1485059340 26344 195.159.176.226 (22 Jan 2017 04:29:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jan 2017 04:29:00 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 22 05:28:56 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cV9lq-0005oC-T8 for ged-emacs-devel@m.gmane.org; Sun, 22 Jan 2017 05:28:51 +0100 Original-Received: from localhost ([::1]:34397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cV9lu-0000hE-FK for ged-emacs-devel@m.gmane.org; Sat, 21 Jan 2017 23:28:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cV9lo-0000h9-HX for emacs-devel@gnu.org; Sat, 21 Jan 2017 23:28:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cV9ll-0006Xm-EK for emacs-devel@gnu.org; Sat, 21 Jan 2017 23:28:48 -0500 Original-Received: from [195.159.176.226] (port=43961 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cV9ll-0006XX-7l for emacs-devel@gnu.org; Sat, 21 Jan 2017 23:28:45 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cV9lN-0003Th-5z for emacs-devel@gnu.org; Sun, 22 Jan 2017 05:28:21 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:v7IMBhEquC7Q0QJ0Dt02VfUWoYM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211517 Archived-At: >>> So https://debbugs.gnu.org/cgi/bugreport.cgi?bug=15485 is fixed? >> No, but I'm not sure it's a bug. It's the way `add-abbrev` works. >> The abbrev-tables themselves don't have that restriction. > So what does abbrev--check-chars inside define-mode-abbrev?: add-abbrev and define-mode-abbrev: même combat! The abbrev-tables themselves don't have that restriction. Clearly, you've looked at the definition of define-mode-abbrev, so I hope you realized that this definition is extremely short: it's a very thin layer above `define-abbrev`. Which means it'd be rather easy to define such a layer which doesn't have those limitations (since define-abbrev doesn't have those limitations). Patches welcome (with appropriate paperwork, of course). Stefan PS: But note that it's not quite as simple as I make it sound: in order to define a non-word abbrev, the abbrev-table has to specify a different :regexp property.