unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tom Tromey <tom@tromey.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master dbb29d7: Add info-lookup help for gdb-script-mode
Date: Sun, 05 Feb 2017 00:01:15 -0500	[thread overview]
Message-ID: <jwvo9yh9qxa.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <87zii18cm8.fsf@tromey.com> (Tom Tromey's message of "Sat, 04 Feb 2017 21:50:39 -0700")

> --- a/lisp/progmodes/autoconf.el
> +++ b/lisp/progmodes/autoconf.el
> @@ -35,6 +35,8 @@
> 
>  ;;; Code:
> 
> +(require 'info-look)
> +
>  (defvar autoconf-mode-map (make-sparse-keymap))
> 
>  (defvar autoconf-mode-hook nil
> @@ -73,6 +75,49 @@ autoconf-current-defun-function
>                              t)
>          (match-string-no-properties 1))))
> 
> +(info-lookup-maybe-add-help
> + :mode 'autoconf-mode

Maybe a better approach would be for the major mode to set an
`info-lookup-<something>` variable, instead.  This would also save us
from (require 'info-look), which would probably also fix the problem you
had with emacs-lisp-mode.

> + :other-modes '(m4-mode))

I guess we could do replace the above with

    (require 'm4-mode)
    [...]
    (defconst autoconf-info-lookup-thingy
      `(...
        :other-modes ,m4-info-lookup-thingy))
    

-- Stefan



  reply	other threads:[~2017-02-05  5:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170117224028.8928.65103@vcs.savannah.gnu.org>
     [not found] ` <20170117224028.A68812201B9@vcs.savannah.gnu.org>
2017-01-18  3:48   ` [Emacs-diffs] master dbb29d7: Add info-lookup help for gdb-script-mode Stefan Monnier
2017-01-18  4:34     ` Tom Tromey
2017-01-18 14:21       ` Stefan Monnier
2017-02-05  4:50         ` Tom Tromey
2017-02-05  5:01           ` Stefan Monnier [this message]
2017-02-05 15:28           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvo9yh9qxa.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).