From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Sun, 16 Apr 2017 15:22:53 -0400 Message-ID: References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <83r30vh2k3.fsf@gnu.org> <83bmrwfg43.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492370755 24235 195.159.176.226 (16 Apr 2017 19:25:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 19:25:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 21:25:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czpnw-000682-SH for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 21:25:48 +0200 Original-Received: from localhost ([::1]:33362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czpo1-0007qw-5h for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 15:25:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czpnQ-0007qe-Te for emacs-devel@gnu.org; Sun, 16 Apr 2017 15:25:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czpnN-00029m-Qa for emacs-devel@gnu.org; Sun, 16 Apr 2017 15:25:16 -0400 Original-Received: from [195.159.176.226] (port=56054 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czpnN-00029I-Jy for emacs-devel@gnu.org; Sun, 16 Apr 2017 15:25:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1czpnD-0005Ez-N4 for emacs-devel@gnu.org; Sun, 16 Apr 2017 21:25:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:l2Vec0O1E/LQ+QmrLl25LBlBQlQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214022 Archived-At: > Thanks, but I'm not interested. This code existed for years, and it > never bothered you or anyone else, so we won't change it now. It's a (cleaner) alternative to the fix below: commit 96ef9ccd1b0a28c774ad5b9ffbfb811de540eb30 Author: Martin Rudalics Date: Wed Oct 3 10:50:49 2012 +0200 Have kill-this-buffer don't do anything when frame is not alive or visible (Bug#8184). * menu-bar.el (kill-this-buffer): Don't do anything when `menu-frame' is not alive or visible (Bug#8184). so, yes, it's been around for a few years but it was pretty ugly. Stefan