From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable.
Date: Tue, 27 Mar 2018 16:06:15 -0400 [thread overview]
Message-ID: <jwvo9j9qoc3.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: x1zi2tl2lp.fsf@fencepost.gnu.org
>> What's the intended meaning of this nil?
> I assume nil means 1. Doesn't seem particularly sensible, but there you go.
Until now it didn't: it was taken as an instruction to execute, i.e.
(benchmark-run nil (setq m (1+ 0)))
is treated as
(benchmark-run 1 (progn nil (setq m (1+ 0))))
rather than
(benchmark-run 1 (setq m (1+ 0)))
It just happens to do the same. The same holds for
(benchmark-run (+ 3 4) (setq m (1+ 0)))
which behaves like
(benchmark-run 1 (+ 3 4) (setq m (1+ 0)))
> Whatever happens, benchmark-run and benchmark-run-compiled should be
> consistent.
Oh, right, I did miss this one, thanks,
Stefan
prev parent reply other threads:[~2018-03-27 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180327010741.32424.61536@vcs0.savannah.gnu.org>
[not found] ` <20180327010741.DB51620512@vcs0.savannah.gnu.org>
2018-03-27 1:26 ` master c7d2a0d: * lisp/emacs-lisp/benchmark.el (benchmark-run): Allow variable Glenn Morris
2018-03-27 2:08 ` Stefan Monnier
2018-03-27 19:50 ` Glenn Morris
2018-03-27 20:06 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo9j9qoc3.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).