From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [RFC PATCH] Per-window face support Date: Mon, 18 Jun 2018 21:21:42 -0400 Message-ID: References: <5e08587a56ad528599ed5fb259be6335.squirrel@dancol.org> <83muw5vdtr.fsf@gnu.org> <83zhzvyqfy.fsf@gnu.org> <83lgbezs6q.fsf@gnu.org> <6b522145569975d52266e29e8122e86b.squirrel@dancol.org> <50a1e0f98f6cfc5e55fdc2b7df5000b5.squirrel@dancol.org> <1dedb08954732c4e59b8c3f61e13dc7c.squirrel@dancol.org> <5b8d8c42dc341ad85081e400f3fd20e1.squirrel@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529371225 12118 195.159.176.226 (19 Jun 2018 01:20:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2018 01:20:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 19 03:20:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV5Ji-00031N-BR for ged-emacs-devel@m.gmane.org; Tue, 19 Jun 2018 03:20:18 +0200 Original-Received: from localhost ([::1]:38302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5Lp-0004Yl-IR for ged-emacs-devel@m.gmane.org; Mon, 18 Jun 2018 21:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5Li-0004Yd-Nk for emacs-devel@gnu.org; Mon, 18 Jun 2018 21:22:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5Lf-0006cZ-Em for emacs-devel@gnu.org; Mon, 18 Jun 2018 21:22:22 -0400 Original-Received: from [195.159.176.226] (port=53785 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5Le-0006bH-KV for emacs-devel@gnu.org; Mon, 18 Jun 2018 21:22:19 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fV5JV-0002lZ-LA for emacs-devel@gnu.org; Tue, 19 Jun 2018 03:20:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 10 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:uFZMqFN2iCBIyRIdoZBdYPhdTM8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226484 Archived-At: > I fear this would lead to a big slowdown in assq, memq, and many other > inner loops that now check EQ. Replacing that with EQL, even if it is > open-coded, would require testing the type first. I doubt it'd be "big", but yes, it probably slows things down a bit. I'm using such a patch and haven't noticed any slowdown, but I admit I haven't bothered to try and measure it. Stefan