From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Date: Fri, 19 Oct 2018 11:24:23 -0400 Message-ID: References: <20181017063829.3775.67018@vcs0.savannah.gnu.org> <20181017063831.03DCB2044D@vcs0.savannah.gnu.org> <810f1e04-1117-476d-9a7d-d57002609bf8@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539962565 22565 195.159.176.226 (19 Oct 2018 15:22:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2018 15:22:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 19 17:22:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDWbp-0005mb-1C for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 17:22:41 +0200 Original-Received: from localhost ([::1]:51099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDWdv-0005tZ-5V for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 11:24:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDWdj-0005sX-Qn for emacs-devel@gnu.org; Fri, 19 Oct 2018 11:24:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDWde-0007AD-Tx for emacs-devel@gnu.org; Fri, 19 Oct 2018 11:24:39 -0400 Original-Received: from [195.159.176.226] (port=37219 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDWdd-0006ya-2i for emacs-devel@gnu.org; Fri, 19 Oct 2018 11:24:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1gDWbT-0005Ox-Rt for emacs-devel@gnu.org; Fri, 19 Oct 2018 17:22:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:h63LJ3yeFb7lH7wabdAb+JJ9iWk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230493 Archived-At: >> Hmm... while it's true that currently, I don't know of a package which >> provides non contiguous regions other than rectangular regions, > zones.el does. Could we add it to elpa.git? >> Maybe we need to extend the API of noncontiguous regions so you can >> tell which "special mode" is associated with it (if any)? > I don't understand the question. Could you elaborate? > Searching your msg for "special" didn't help. The code I quoted said: (when region-noncontiguous (rectangle-mark-mode))) I don't know why he needs to enable rectangle-mark-mode here, but if it's needed in the case of rectangular regions (apparently his code assumes that "noncontiguous" is synonym with "rectangular") maybe some other mode might be needed for other noncontinuous regions, in which case, the region should maybe carry with itself its associated mode. But to know what to do, we first need to know more about why he has code like the above. Stefan