From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Subject: Re: file-exists-p on empty string
Date: Wed, 27 Feb 2019 11:15:44 -0500 [thread overview]
Message-ID: <jwvo96xcj42.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m21s3tfcgi.fsf@gmail.com> (Robert Pluim's message of "Wed, 27 Feb 2019 17:00:45 +0100")
>> I don't think we can change the above behavior without introducing other
>> odd behaviors. E.g. currently (file-name-nondirectory "/a/b/") return "",
>> which is consistent with the above behavior.
>
> ? file-name-nondirectory doesnʼt use expand-file-name anywhere, and we
> can fix file-exists-p without changing expand-file-name, so I donʼt
> follow you here.
It considers "" as the name of the directory, just like `file-exists-p`
and `expand-file-name` (and pretty much all other operations that take
a file name).
This is really not specific to `file-exists-p`: it's a general design of
Elisp's handling of file names.
If we consider "" as an invalid file name, then I think
(file-name-nondirectory "/a/b/") should be changed to return ".", and
I'd be surprised if it's the only change we'd need to do.
Stefan
next prev parent reply other threads:[~2019-02-27 16:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 12:29 file-exists-p on empty string Evgeny Zajcev
2019-02-27 14:15 ` Michael Albinus
2019-02-27 15:29 ` Troy Hinckley
2019-02-27 15:43 ` Robert Pluim
2019-02-27 16:01 ` Michael Albinus
2019-02-27 16:55 ` Eli Zaretskii
2019-02-27 18:09 ` Michael Albinus
2019-02-27 16:11 ` Eli Zaretskii
2019-02-27 16:16 ` Robert Pluim
2019-02-27 16:30 ` Andreas Schwab
2019-02-27 19:40 ` lg.zevlg
2019-02-27 15:53 ` Stefan Monnier
2019-02-27 16:00 ` Robert Pluim
2019-02-27 16:15 ` Stefan Monnier [this message]
2019-02-27 16:09 ` Eli Zaretskii
2019-02-27 18:42 ` lg.zevlg
2019-02-27 18:46 ` Eli Zaretskii
2019-02-27 19:04 ` lg.zevlg
2019-02-27 19:16 ` Eli Zaretskii
2019-02-27 19:29 ` lg.zevlg
2019-02-27 19:30 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2019-02-27 20:07 lg.zevlg
2019-02-27 21:18 ` Stefan Monnier
2019-02-27 22:01 ` Drew Adams
2019-02-28 3:24 ` Stefan Monnier
2019-03-06 9:51 ` Michael Albinus
2019-03-08 6:11 ` Stefan Monnier
2019-03-09 8:48 ` Michael Albinus
2019-02-27 22:09 lg.zevlg
2019-02-27 22:23 ` Drew Adams
2019-02-27 22:41 ` Evgeny Zajcev
2019-02-27 23:23 ` Drew Adams
2019-02-28 0:08 ` Evgeny Zajcev
2019-02-28 1:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo96xcj42.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).