From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Daniel Pittman <slippycheeze@google.com>, emacs-devel@gnu.org
Subject: Re: TRAMP VC optimization: also breaks process filters -_-
Date: Tue, 07 May 2019 11:42:24 -0400 [thread overview]
Message-ID: <jwvo94ee0up.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87lfzi1e4l.fsf@gmx.de> (Michael Albinus's message of "Tue, 07 May 2019 17:24:42 +0200")
> Yes, the analysis is correct. However, we don't need to check this for
> every Tramp invocation.
Indeed, when the first arg of expand-file-name is absolute the second
arg shouldn't matter.
> Daniel's reports have been covered always
> vc-registered. And indeed, the related `tramp-vc-file-name-handler'
> seems to expect always a Tramp file name, which is not true for filters
> and sentinels which run for non-Tramp processes.
I don't understand what filers and sentinels have to do with it.
> Daniel, does the appended patch fixes the issue for you?
The patch looks good to me, at least,
Stefan
next prev parent reply other threads:[~2019-05-07 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 18:13 TRAMP VC optimization: also breaks process filters -_- Daniel Pittman
2019-05-06 17:54 ` Stefan Monnier
2019-05-07 15:24 ` Michael Albinus
2019-05-07 15:42 ` Stefan Monnier [this message]
2019-05-07 15:51 ` Michael Albinus
2019-05-07 16:19 ` Stefan Monnier
2019-05-08 6:35 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo94ee0up.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=slippycheeze@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).