From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 55cdebc: Make Tramp compatible to recent progress-reporter-update
Date: Sat, 15 Jun 2019 12:28:48 -0400 [thread overview]
Message-ID: <jwvo92ystk2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ef3v3wdv.fsf@gmx.de> (Michael Albinus's message of "Sat, 15 Jun 2019 13:45:16 +0200")
>>> + (if (equal (tramp-compat-funcall 'func-arity #'progress-reporter-update)
>>> + '(1 . 3))
>> This gives the wrong result if progress-reporter-update is advised
>> (e.g. for `debug-on-entry`, or `trace-function`, or ...)
> Do you know a better test?
None is perfect. Other than looking at the Emacs version number, you
can also do
(condition-case (progress-reporter-update ...)
(wrong-number-of-arguments (progress-reporter-update ...)))
I find this latter one less troublesome in practice than testing arity,
Stefan
prev parent reply other threads:[~2019-06-15 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190615093820.29808.75496@vcs0.savannah.gnu.org>
[not found] ` <20190615093822.02DC9209BF@vcs0.savannah.gnu.org>
2019-06-15 10:47 ` [Emacs-diffs] master 55cdebc: Make Tramp compatible to recent progress-reporter-update Stefan Monnier
2019-06-15 11:45 ` Michael Albinus
2019-06-15 16:28 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo92ystk2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).