From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: VOTE: Changing completions-common-part face's default Date: Fri, 08 Nov 2019 16:42:50 -0500 Message-ID: References: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> <87pni7p83l.fsf@gmail.com> <87h83ipoi0.fsf@gmail.com> <93235eb5-8e04-7182-e2a4-49fbe610ee2b@yandex.ru> <28d4ae09-daca-324b-2fa6-9d7138d710fa@yandex.ru> <834kzeb1cc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103447"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 08 22:43:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTC25-000Ql7-Ru for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 22:43:06 +0100 Original-Received: from localhost ([::1]:60788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTC24-0003WO-8h for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 16:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTC1x-0003V1-TE for emacs-devel@gnu.org; Fri, 08 Nov 2019 16:42:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTC1w-000109-E1 for emacs-devel@gnu.org; Fri, 08 Nov 2019 16:42:57 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6989) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iTC1u-0000zE-Lm; Fri, 08 Nov 2019 16:42:54 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BB76D1004C7; Fri, 8 Nov 2019 16:42:53 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 53E041002FC; Fri, 8 Nov 2019 16:42:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1573249372; bh=ToXlnDkdY1zaUOlaIwbjq1dFzVYOwCCF3OmHGuU+AXw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AZCOPN8M1HqMNegYei4rRw6IfXPLNgMAn2faf4MGNyhG1hF1dybSO43QVXHAJo9jy 3+wincrWWhNM+oGEBL7Z8m28OPdJ5+5qj6vd7DTVhq+oADMXDTMad5x+njmw9Qv8mY gWx801m1Lsw5cp1kfrMKBhTZvIS6W2lleaKtEuVPkuP9ljejhs60Lb4rEw/vHR6yq2 06bysk9D4Gpt49HIhN6YsdPFEQMRfCMzSKwqO1OZ3RlqPJxm/bCcEP+4sFFm3GDvRX cURRX5gx+MO0oqBIf/kzbeHTWiVt4zJ4CG66exssN6ELovf/JQzGJBs7D7lPwSD3QP Q1VaWpI/MbPEA== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9E6201210EA; Fri, 8 Nov 2019 16:42:51 -0500 (EST) In-Reply-To: <834kzeb1cc.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Nov 2019 21:43:47 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242011 Archived-At: > Please tell which face will use this, whether as foreground or as > background color, and what will that face highlight in various > completion scenarios. (I think I know the answers, but I'm so > flabbergasted by the other thread that I no longer believe my memory > and my ability to draw conclusions from what you mentioned in this > one. Sorry.) Concretely the patch I'm suggesting is the one below, which makes it so the "common-part" (e.g. the common prefix in the case basic completion) of the completions has a blue3 foreground rather than being identical to `default` (we'd also want to find a color for the dark background case, but... one step at a time). Stefan diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 43dd277a2e..e4c4edd114 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1687,7 +1687,9 @@ completions-first-difference "Face for the first character after point in completions. See also the face `completions-common-part'.") -(defface completions-common-part '((t nil)) +(defface completions-common-part + '((((background light)) :foreground "blue3") + (t nil)) "Face for the parts of completions which matched the pattern. See also the face `completions-first-difference'.")