unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: master 3fc859d: Go back to iso-2022-7bit for titdic-cnv.el again
Date: Mon, 06 Jan 2020 12:53:05 -0500	[thread overview]
Message-ID: <jwvo8vgzdb4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83mub0ecnk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 06 Jan 2020 19:07:59 +0200")

> If the charset properties are not important here at all (I'm not sure
> yet), then we should rewrite that code not to "select" one of 2
> identical strings.  And if the charset is important, we should still
> have only one copy of each string, but propertize it with the charset
> selected according to the big5-p flag.

Agreed.  My point was mostly that reverting the encoding to iso-2022 is
probably not the best course of action and that other than "uselessly
complex code" I couldn't find a concrete problem description that can
help decide whether the charset properties are actually relevant.

I'm beginning to believe they're not: they may have been back in
Emacs<23 when it was important to pick the right characters from the
right charset, but since we switched to Unicode for our internals, the
distinction has disappeared.


        Stefan




  reply	other threads:[~2020-01-06 17:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200105203051.21185.19313@vcs0.savannah.gnu.org>
     [not found] ` <20200105203053.36B932105B@vcs0.savannah.gnu.org>
2020-01-05 20:55   ` master 3fc859d: Go back to iso-2022-7bit for titdic-cnv.el again Stefan Monnier
2020-01-06 17:07     ` Eli Zaretskii
2020-01-06 17:53       ` Stefan Monnier [this message]
2020-01-06 18:12         ` Andreas Schwab
2020-01-06 18:21           ` Stefan Monnier
2020-01-06 18:26           ` Eli Zaretskii
2020-01-06 18:24         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvo8vgzdb4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).