From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Delete variables obsolete since Emacs 23 Date: Sat, 16 May 2020 22:52:46 -0400 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 17 04:54:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ja9Rd-000FEc-La for ged-emacs-devel@m.gmane-mx.org; Sun, 17 May 2020 04:54:29 +0200 Original-Received: from localhost ([::1]:49072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ja9Rc-0005gg-L8 for ged-emacs-devel@m.gmane-mx.org; Sat, 16 May 2020 22:54:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja9Q2-0003oA-QN for emacs-devel@gnu.org; Sat, 16 May 2020 22:52:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja9Q1-00031a-V1 for emacs-devel@gnu.org; Sat, 16 May 2020 22:52:50 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0600C1002FC; Sat, 16 May 2020 22:52:49 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5177F100275; Sat, 16 May 2020 22:52:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1589683967; bh=cVP3jHSlJuMu5df57dX/P5Emqhk34KEChxbbpYzcjv0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vu3xE6Y48gJ7ofyfUVaAbcnJiZU72PnxdbQwaJ+I650QnlRSFv8LvpSNaEN/IaAav F24c7JzrcYu7nnjNF/I76pxk1x8gnEHDGpLg4VDv5pss+KdhnNVqcNf+/DdKX6n1Nj paJ9oscO5NWTI64BPtxN60tTahMDw+IbjMWlOGxqA89yj38cM2e57v8P830/P16dXx TSzIPZ4nLkaJrLIdn3FMVg2AIuxFUhwXO8UFMPlhxWWIZcqVyRHimtW5zEIl4bxujr hHEYdJGCCFPwicStafaKPtfkLICj+/Zq9f7ggiS06lCUkXpxoUDoTm5QOIF03FBZ3f LuhkTsZjR0DRQ== Original-Received: from alfajor (unknown [216.154.27.250]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DFE911202BB; Sat, 16 May 2020 22:52:46 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Sat, 16 May 2020 09:18:48 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/16 22:42:01 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250550 Archived-At: > 3. Note the added FIXME in `vc-default-working-revision', where I'm not > sure if it should be declared obsolete or not. See Stefan M's commit > 6e5d0e9e73. This function is never called directly (the only way it could be called was via (vc-call-backend .. 'working-revision) for backends that defined `vc--workfile-revision` instead of `vc--working-revision`. So a `make-obsolete` would have been ineffective (since it's never called directly, the byte-compiler would never emit an obsolescence warning) and I replaced it with a more annoying "message". Since noone complained about that message, I think it's definitely safe to remove the function. > 4. The variable `translation-table-for-input' was declared obsolete with > in Emacs 23.1 and has the following comment. I'm not sure what to do > about it, if anything. > > ;; This was introduced in 21.4 for pre-unicode unification. That > ;; usage was rendered obsolete in 23.1, which uses Unicode internally. > ;; Other uses are possible, so this variable is not _really_ obsolete, > ;; but Stefan insists to mark it so. It's not obsolete in the sense that there's nothing to replace it, indeed. But it's been completely unused since Emacs-23.1 so it's complexity that's not pulling its weight. Stefan