From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Mon, 14 Sep 2020 16:20:19 -0400 Message-ID: References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <878sddz72o.fsf@elephly.net> <837dswbept.fsf@gnu.org> <87r1r4xq74.fsf@elephly.net> <83imcg9shm.fsf@gnu.org> <87a6xsxhry.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18606"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: casouri@gmail.com, spacibba@aol.com, emacs-devel@gnu.org, ams@gnu.org, ghe@sdf.org, Eli Zaretskii , tecosaur@gmail.com To: Ricardo Wurmus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 14 22:21:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHuyU-0004lY-P0 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 22:21:18 +0200 Original-Received: from localhost ([::1]:45644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHuyS-0001Os-21 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 16:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHuxf-0000oX-IF for emacs-devel@gnu.org; Mon, 14 Sep 2020 16:20:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHuxd-0003YI-2R; Mon, 14 Sep 2020 16:20:26 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 689C610022D; Mon, 14 Sep 2020 16:20:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A9D5E100222; Mon, 14 Sep 2020 16:20:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600114820; bh=CQS7TudKmuUwWlBNSilwk8vAE4SArsNdJwgHLV0fGyk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F3ziN43NvAfmxJllQUozMADv3uFJMmk/w++5KNfUqQq/Jg521n78t8O7rNrgbIvLB 8YNw0mTQU6KAIE7kjoQKnE+jEJQMmA1hyoBVs25JsLhknsaqBLkg+qrqo3Y9jFU+Tj wqdDOC9hGl+Nkm/8OUF49mYXvEPGkByYMbiQlnOOzvlWTFxXz9H8pFUVU+219Smu2v vWAWy4ZXb1l7PJ4weM4AqTD8NPZg+7sEHg0JvU/Q2a72mli131JM15d/diZNFaK/sQ eg8fCHJZytBYjZLzqJeA++IDgzaoZxqJWFdfComW1VzuEYzJ0haylxd5yBmYldYGiO vNMnhT76Rz88g== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1ED991202CE; Mon, 14 Sep 2020 16:20:20 -0400 (EDT) In-Reply-To: <87a6xsxhry.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 14 Sep 2020 21:47:13 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 16:20:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255690 Archived-At: > I don=E2=80=99t understand. There is a clear problem here in that the > font-lock-comment-face is dark red and the region colour is whatever the > GTK theme says it should be. So unless font-lock-comment-face is also > set according to the GTK theme=E2=80=99s colours there is no way to avoid= this > unfortunate combination of colours (dark red on dark background) without > customization. Does Gtk offer some setting for the color of "comments"? What do other applications do? > FWIW neither the dark red colour nor the region background colour > changes when I change frame-background-mode. Maybe there's a bug here. The color of `font-lock-comment-face` *should* change. If you can reproduce this, please provide a recipe to `report-emacs-bug`. The code says: (defface font-lock-comment-face '((((class grayscale) (background light)) :foreground "DimGray" :weight bold :slant italic) (((class grayscale) (background dark)) :foreground "LightGray" :weight bold :slant italic) (((class color) (min-colors 88) (background light)) :foreground "Firebrick") (((class color) (min-colors 88) (background dark)) :foreground "chocolate1") (((class color) (min-colors 16) (background light)) :foreground "red") (((class color) (min-colors 16) (background dark)) :foreground "red1") (((class color) (min-colors 8) (background light)) :foreground "red") (((class color) (min-colors 8) (background dark)) :foreground "yellow") (t :weight bold :slant italic)) "Font Lock mode face used to highlight comments." :group 'font-lock-faces) So when in "dark background" mode, `font-lock-comment-face` should be using `chocolate1` rather than `Firebrick`. Stefan