From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: toggle-light-dark-mode Date: Wed, 16 Sep 2020 16:59:22 -0400 Message-ID: References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <20200912194652.nrcx2fjg7n4j54ns@Ergus> <87blia32b7.fsf@gmail.com> <871rj30vzq.fsf@gmail.com> <87d02mop87.fsf@mail.linkov.net> <87tuvyztq5.fsf@gmail.com> <87imce0zbr.fsf@mail.linkov.net> <87k0wtfpim.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23618"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Caio Henrique , emacs-devel@gnu.org, Juri Linkov To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 16 23:01:09 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIeY8-00061u-0o for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Sep 2020 23:01:08 +0200 Original-Received: from localhost ([::1]:59914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIeY7-0007Ed-0R for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Sep 2020 17:01:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIeWW-0006F3-TH for emacs-devel@gnu.org; Wed, 16 Sep 2020 16:59:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIeWU-0005Nc-Jb for emacs-devel@gnu.org; Wed, 16 Sep 2020 16:59:28 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C33E48009B; Wed, 16 Sep 2020 16:59:24 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 070FB804EC; Wed, 16 Sep 2020 16:59:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600289963; bh=6vGHGhPosh+gXq7RbFypfbkYl9uLZ/0N6Jx3unqKkrA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VYU4YffmcNQWvRvmwYk74ajTuSIfqorpIyGzOxIBpLybAHKMIIRGd/BWSNZCv3liF vewg/oI8tecQuATGuSgqsPoUvpJwIf0ifpZssOuhjuWFwBu3MUPZ5dgAVl99X64Zak OIQbwUqTKGGIIzEC/JLKolqUsgYDnc6huXiAirjSwlor/MfJGiv5n7teXkmeGRrMXl AAar9lgMzv1TDvMSCLk3gp5rmHj68mLAX7Vcg579Pg3ZmuDLAbyb+R8tReNiJVxYPn RkzyFofzTs5wyNbEzSYpLCuU3EK5x0B/eOtgdmFUUh0mqXW/BRt5m3CLIKdrn850W4 d3PKNByFGS7Sw== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C9CB9120749; Wed, 16 Sep 2020 16:59:22 -0400 (EDT) In-Reply-To: <87k0wtfpim.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 16 Sep 2020 23:14:09 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 16:59:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255932 Archived-At: >> I wonder why other themes don't support both modes? For example, why there >> is separate light tango-theme and tango-dark-theme, but not one tango-theme >> supporting dark and light modes? And why separate light modus-operandi-theme >> and dark modus-vivendi-theme, but not one modus-theme with both modes? > Indeed, defface already provides the means to account for different > display specs. [...] > Going forward, it may be preferable to follow your suggestion. Yes and no: I'm not sure the end users will really care for a two-step choice of theme where they first need to choose a theme and then figure out how on earth to switch from the dark version to the light or vice-versa. The background-mode feature of face-specs is very useful for the default face settings to work well regardless of the choice of foreground/background for the `default` face and that's important when that face's default is inherited from external settings (like Gtk or Xresources). But in the case of modus-themes, the default face's color is chosen by the theme, so it doesn't make much sense to say "if the default face looks like this, do one thing otherwise do another" since we already know what the default face looks like. Stefan