From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Sorting command completions by recency Date: Wed, 17 Feb 2021 15:58:33 -0500 Message-ID: References: <875z2qslwk.fsf@mail.linkov.net> <877dn635oe.fsf@gnus.org> <9720b886-39aa-9a52-8c74-144fc7600175@posteo.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Juri Linkov , emacs-devel@gnu.org To: Clemens Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 22:36:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCUV6-0000CV-Cr for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 22:36:48 +0100 Original-Received: from localhost ([::1]:41986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCUV5-0005k6-E6 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 16:36:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTuD-0002nO-PH for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:58:41 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47107) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTuB-000086-3B for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:58:40 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5F6F980052; Wed, 17 Feb 2021 15:58:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A470380497; Wed, 17 Feb 2021 15:58:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613595515; bh=NXDO8hNoIpCVq45ffRUTdjQ0C/rtJ5sZHFkwlUsAHeA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KNyE0i1wAHCSxhG3PZTm8O/UEair6Ti64WeeD78A+F6QSkCcdYBDvnuPg3sHerlTE 6gdITch9q01WVG6jFVwFL0doTAfBIJxCoxDZGYqaCKSgwURP3f0m4Ldd3Wxo37VCpD WsnswdodNfvLR9Tf+BSctDBdEpgIYrN7p1L/7Oz33MAxnQdAMLU14uVdAM+Kfj6a03 e2LFsxWVwBZcdJitCmvt7rXQz5WaevFyI8JZAwHmVKXF7buzIVWEzNrIugNZ7aVVic c6eze6CeWyUEz9FKjr+JxDXMnb1JznZym7bM9ikEazwaX4idWZ2eMJVN2xbGMU3L0e HxNa70+0F6kHA== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6AEBF120278; Wed, 17 Feb 2021 15:58:35 -0500 (EST) In-Reply-To: <9720b886-39aa-9a52-8c74-144fc7600175@posteo.de> (Clemens's message of "Wed, 17 Feb 2021 21:03:57 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265086 Archived-At: >>>> This code puts the recent commands at the top as well, >>>> but probably it needs to be opt-in: >>> Makes sense to me, and, yes. >> FWIW, the minibuffer.el code already uses this kind of sorting for the >> list of completions used in things like `icomplete` and >> `completion-cycle-threshold`. >> For *Completions* the sort was kept alphabetical so far because that's >> also useful (for example in the case of M-x completion, it makes it >> easier to skip over blocs of commands sharing the same prefix). >> So, while I think it can be useful to sort by some kind of "guessed >> usefulness" such as presence in the history, I don't think this should >> be forced by the completion table of commands. > Maybe it would make sense to have a general option to configure this history > sorting. When the table doesn't specify its own sorting one could opt in to > always sort base on history. Agreed. It'd make sense to have it as a global option, like `completion-cycle-threshold` and it would also make sense to be able to override it individually via `completion-category-overrides` (which is also the case for the cycling behavior). Stefan