From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Why does signaling an error not call set-message-function? Date: Tue, 05 Apr 2022 10:19:41 -0400 Message-ID: References: <87tub8hsax.fsf@blind.guru> <83h777ep5r.fsf@gnu.org> <87sfqrg2hf.fsf@blind.guru> <83bkxfen5h.fsf@gnu.org> <837d83ekeu.fsf@gnu.org> <834k37ejk5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: mlang@blind.guru, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 05 16:21:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbk3V-0008RY-Fz for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 16:21:13 +0200 Original-Received: from localhost ([::1]:46882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbk3U-0004Cu-2n for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Apr 2022 10:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbk2A-0003DP-Aq for emacs-devel@gnu.org; Tue, 05 Apr 2022 10:19:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbk27-0007ny-Am; Tue, 05 Apr 2022 10:19:48 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B63651001E0; Tue, 5 Apr 2022 10:19:44 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 114A610009E; Tue, 5 Apr 2022 10:19:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1649168383; bh=d1LqTZnbm6VyRWFKrD7KKSTq+iX/amGdah6DECay9Ys=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CpwfCqcJt4cSB3mEil0WFYRMk4KxkbslbbzOT/rpSRNMVrPCr/rnuwgljoib8mGfN AEwWQFuFkMNR6BikOcn0h7wYKkfH/cmbq4Ws3+BiAlhfRio2ve1OYuBxki+UhkZxo8 4Pk5Bga1z1wOYzixx2ENfQThtUPYC5iGKRA5kUoLzB9+a9Zpw0kOuaRCyPqpjvkBu7 9X70iWf1rr1bZmNVAUTaxhO9POW/urcdRoqow7SfsbSkA7/82EgU7gqsvOaanAh3QV jQQppC0mA5fkz1IxDTX/sqZjTn0g5bxR6u9hNoleqAiZUMovSnm3ACUbn8HGUPZiJG /bs8HyG5Uel6A== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1A34120163; Tue, 5 Apr 2022 10:19:42 -0400 (EDT) In-Reply-To: <834k37ejk5.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 Apr 2022 16:39:06 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287819 Archived-At: >> I don't see a problem running arbitrary ELisp code at that time. >> After all, we already exited the error-signaling context > We did? You made me doubt, but indeed I see: Lisp_Object command_loop_2 (Lisp_Object handlers) { register Lisp_Object val; =20=20=20=20 do val =3D internal_condition_case (command_loop_1, handlers, cmd_erro= r); while (!NILP (val)); =20=20=20=20 return Qnil; } So `cmd_error` is run after we exit the error-signaling context. Also while looking at it, I saw tht `cmd_error` then calls `cmd_error_internal` which calls `command-error-function`: command-error-function is a variable defined in =E2=80=98C source code= =E2=80=99. =20=20=20=20 Its value is =E2=80=98help-command-error-confusable-suggestions=E2=80=99 =20=20=20=20 Function to output error messages. Called with three arguments: - the error data, a list of the form (SIGNALED-CONDITION . SIGNAL-DATA) such as what =E2=80=98condition-case=E2=80=99 would bind its variable= to, - the context (a string which normally goes at the start of the message= ), - the Lisp function within which the error was signaled. =20=20=20=20 Also see =E2=80=98set-message-function=E2=80=99 (which controls how non= -error messages are displayed). So we do already allow running arbitrary ELisp code in there ;-) Stefan