From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Sun, 28 May 2006 19:54:07 -0400 Message-ID: References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> <877j45rj3w.fsf@lrde.org> <87odxhq1ah.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1148860467 14542 80.91.229.2 (28 May 2006 23:54:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 28 May 2006 23:54:27 +0000 (UTC) Cc: Agustin Martin , emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 29 01:54:24 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FkV5S-0006Z7-HR for ged-emacs-devel@m.gmane.org; Mon, 29 May 2006 01:54:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FkV5S-0008MG-2z for ged-emacs-devel@m.gmane.org; Sun, 28 May 2006 19:54:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FkV5G-0008KC-DE for emacs-devel@gnu.org; Sun, 28 May 2006 19:54:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FkV5E-0008Gp-KQ for emacs-devel@gnu.org; Sun, 28 May 2006 19:54:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FkV5E-0008GU-G3 for emacs-devel@gnu.org; Sun, 28 May 2006 19:54:08 -0400 Original-Received: from [209.226.175.54] (helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FkVAf-0005kP-WC for emacs-devel@gnu.org; Sun, 28 May 2006 19:59:46 -0400 Original-Received: from localhost ([70.55.80.141]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060528235407.DNPJ2009.tomts10-srv.bellnexxia.net@localhost>; Sun, 28 May 2006 19:54:07 -0400 Original-Received: by localhost (Postfix, from userid 20848) id 257788232; Sun, 28 May 2006 19:54:07 -0400 (EDT) Original-To: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) In-Reply-To: <87odxhq1ah.fsf@lrde.org> (=?iso-8859-1?Q?Micha=EBl?= Cadilhac's message of "Sun, 28 May 2006 23:36:54 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55387 Archived-At: > In fact, there is already a configuration that would lead to the non > deletion of the PID from the list: > - Call to delete_process, > - Interrupted by a signal before inserting in deleted_processes_list , > - Deletion from process_alist, How can this happen? Are you saying that a signal handler may delete the process from process_alist? Which signal handler can do that? I do think there's a leak but it goes like this: - catch the SIGCHLD signal - start processing delete-process, which will add the PID to deleted_pid_list even though the signal has already been caught so the pid won't get a chance to be removed. I guess we could check the process's status after adding it to deleted_pid_list, to catch this case. Stefan