* bootstrap fails in byte-op.el
@ 2007-08-23 22:53 Glenn Morris
2007-08-24 0:02 ` Katsumi Yamaoka
2007-08-24 14:39 ` Stefan Monnier
0 siblings, 2 replies; 4+ messages in thread
From: Glenn Morris @ 2007-08-23 22:53 UTC (permalink / raw)
To: emacs-pretest-bug; +Cc: Stefan Monnier
Bootstrapping current trunk fails compiling byte-opt.el:
In toplevel form:
emacs-lisp/byte-opt.el:288:51:Error: Wrong type argument: listp, restp
make[2]: *** [compile] Error 1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bootstrap fails in byte-op.el
2007-08-23 22:53 bootstrap fails in byte-op.el Glenn Morris
@ 2007-08-24 0:02 ` Katsumi Yamaoka
2007-08-24 1:21 ` Glenn Morris
2007-08-24 14:39 ` Stefan Monnier
1 sibling, 1 reply; 4+ messages in thread
From: Katsumi Yamaoka @ 2007-08-24 0:02 UTC (permalink / raw)
To: emacs-devel; +Cc: emacs-pretest-bug
>>>>> Glenn Morris wrote:
> Bootstrapping current trunk fails compiling byte-opt.el:
> In toplevel form:
> emacs-lisp/byte-opt.el:288:51:Error: Wrong type argument: listp, restp
> make[2]: *** [compile] Error 1
It happens when the <test> element of a `(if <test>...)' form is
not a list. How about this?
*** byte-opt.el~ Thu Aug 23 22:01:17 2007
--- byte-opt.el Thu Aug 23 23:52:04 2007
***************
*** 1020,1026 ****
;; (if <test> nil <else...>) ==> (if (not <test>) (progn <else...>))
;; (if <test> <then> nil) ==> (if <test> <then>)
(let ((clause (nth 1 form)))
! (cond ((eq (car clause) 'progn)
(if (null (cddr clause))
;; A trivial `progn'.
(byte-optimize-if `(if ,(cadr clause) ,@(nthcdr 2 form)))
--- 1020,1026 ----
;; (if <test> nil <else...>) ==> (if (not <test>) (progn <else...>))
;; (if <test> <then> nil) ==> (if <test> <then>)
(let ((clause (nth 1 form)))
! (cond ((eq (car-safe clause) 'progn)
(if (null (cddr clause))
;; A trivial `progn'.
(byte-optimize-if `(if ,(cadr clause) ,@(nthcdr 2 form)))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bootstrap fails in byte-op.el
2007-08-24 0:02 ` Katsumi Yamaoka
@ 2007-08-24 1:21 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2007-08-24 1:21 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: emacs-pretest-bug, emacs-devel
Katsumi Yamaoka wrote:
> It happens when the <test> element of a `(if <test>...)' form is
> not a list. How about this?
That certainly fixes bootstrapping.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bootstrap fails in byte-op.el
2007-08-23 22:53 bootstrap fails in byte-op.el Glenn Morris
2007-08-24 0:02 ` Katsumi Yamaoka
@ 2007-08-24 14:39 ` Stefan Monnier
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2007-08-24 14:39 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-pretest-bug
> Bootstrapping current trunk fails compiling byte-opt.el:
> In toplevel form:
> emacs-lisp/byte-opt.el:288:51:Error: Wrong type argument: listp, restp
> make[2]: *** [compile] Error 1
Oops, fixed,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-24 14:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-23 22:53 bootstrap fails in byte-op.el Glenn Morris
2007-08-24 0:02 ` Katsumi Yamaoka
2007-08-24 1:21 ` Glenn Morris
2007-08-24 14:39 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).