From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v Date: Mon, 28 Jul 2008 22:47:21 -0400 Message-ID: References: <20080728224640.GB894@orion.lan> <200807282259.m6SMxLOj027630@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217299668 1492 80.91.229.12 (29 Jul 2008 02:47:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Jul 2008 02:47:48 +0000 (UTC) Cc: Emanuele Giaquinta , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 29 04:48:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KNfGO-00070a-9Z for ged-emacs-devel@m.gmane.org; Tue, 29 Jul 2008 04:48:36 +0200 Original-Received: from localhost ([127.0.0.1]:56333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNfFU-0006Bv-CG for ged-emacs-devel@m.gmane.org; Mon, 28 Jul 2008 22:47:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNfFI-00068N-8Z for emacs-devel@gnu.org; Mon, 28 Jul 2008 22:47:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNfFE-00067D-IU for emacs-devel@gnu.org; Mon, 28 Jul 2008 22:47:27 -0400 Original-Received: from [199.232.76.173] (port=40138 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNfFE-000679-6d for emacs-devel@gnu.org; Mon, 28 Jul 2008 22:47:24 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:42747 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNfFD-0005PK-Po for emacs-devel@gnu.org; Mon, 28 Jul 2008 22:47:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqEEAA0hjkhFxIYw/2dsb2JhbACBW4lFo32BdA X-IronPort-AV: E=Sophos;i="4.31,269,1215403200"; d="scan'208";a="24913476" Original-Received: from 69-196-134-48.dsl.teksavvy.com (HELO pastel.home) ([69.196.134.48]) by ironport2-out.teksavvy.com with ESMTP; 28 Jul 2008 22:47:22 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 092A3806B; Mon, 28 Jul 2008 22:47:21 -0400 (EDT) In-Reply-To: <200807282259.m6SMxLOj027630@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 28 Jul 2008 15:59:21 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101664 Archived-At: >> This hunk is wrong and breaks malloc on os x when building without >> toolkit. The reason to have two macros, MAC_OSX and HAVE_CARBON, was to >> distinguish bare os x support from carbon gui AFAIU. > Unfortunately that is not what the code in configure.in said: But that's partly what admin/CPP-DEFINES says. > What is the right conditional there? Of course, you can expect that some of those macros aren't always used 100% correctly either. Which is why a good CPP-DEFINES file is important, in order to document the intended use, so as to know which uses are correct and which aren't. Stefan