From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v
Date: Mon, 28 Jul 2008 22:47:21 -0400 [thread overview]
Message-ID: <jwvmyk1z9v2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <200807282259.m6SMxLOj027630@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 28 Jul 2008 15:59:21 -0700")
>> This hunk is wrong and breaks malloc on os x when building without
>> toolkit. The reason to have two macros, MAC_OSX and HAVE_CARBON, was to
>> distinguish bare os x support from carbon gui AFAIU.
> Unfortunately that is not what the code in configure.in said:
But that's partly what admin/CPP-DEFINES says.
> What is the right conditional there?
Of course, you can expect that some of those macros aren't always used
100% correctly either. Which is why a good CPP-DEFINES file is
important, in order to document the intended use, so as to know which
uses are correct and which aren't.
Stefan
next prev parent reply other threads:[~2008-07-29 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KNAva-0007QI-CF@cvs.savannah.gnu.org>
2008-07-28 22:46 ` [Emacs-diffs] Changes to emacs/src/emacs.c,v Emanuele Giaquinta
2008-07-28 22:59 ` Dan Nicolaescu
2008-07-28 23:18 ` Emanuele Giaquinta
2008-07-28 23:28 ` Dan Nicolaescu
2008-07-29 7:58 ` Emanuele Giaquinta
2008-07-29 13:13 ` Dan Nicolaescu
2008-07-29 13:40 ` Emanuele Giaquinta
2008-07-29 14:00 ` Dan Nicolaescu
2008-07-29 2:47 ` Stefan Monnier [this message]
2008-07-29 4:43 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmyk1z9v2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=emanuele.giaquinta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).