From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Warnings about keymaps
Date: Mon, 14 Sep 2009 17:46:25 -0400 [thread overview]
Message-ID: <jwvmy4x42yz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <xhab0x736m.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 14 Sep 2009 15:10:25 -0400")
>> The bug can be seen more directly by byte-compiling the file below:
>>
>> (defconst foo nil)
>> (defvar foo nil)
>>
>> Looks like the "assignment-to-constant" warning should be more
>> careful to distinguish defvar from setq.
> This seems a fairly nonsensical thing to do, so why shouldn't the
> compiler warn about it?
It could, but it shouldn't complain about assignment to a constant,
since the defvar will not perform any assignment. I.e. maybe a warning
is OK, but not the warning we currently get.
> The defvar is a best a no-op, at worst a bug
> (if you were expecting it to have an effect).
In the OP's case the defvar was expected to have as effect to "provide
a default value to the var in case it's not defined elsewhere". So it
seems to behave as expected (it's a no-op since the var is defined
elsewhere).
Stefan
next prev parent reply other threads:[~2009-09-14 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 9:04 Warnings about keymaps Eli Zaretskii
2009-09-11 17:34 ` Glenn Morris
2009-09-11 17:43 ` Stefan Monnier
2009-09-14 19:10 ` Glenn Morris
2009-09-14 21:46 ` Stefan Monnier [this message]
2009-09-15 2:45 ` Glenn Morris
2009-09-15 13:40 ` Stefan Monnier
2009-09-17 7:32 ` Glenn Morris
2009-09-17 14:02 ` Stefan Monnier
2009-09-18 22:25 ` Glenn Morris
2009-09-19 0:04 ` Stephen J. Turnbull
2009-09-19 0:43 ` Stefan Monnier
2009-09-15 15:13 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmy4x42yz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).