From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: lisp-completion question Date: Wed, 03 Jul 2013 20:24:45 -0400 Message-ID: References: <8761x1f6e1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372897498 23693 80.91.229.3 (4 Jul 2013 00:24:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Jul 2013 00:24:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 04 02:24:54 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UuXLx-0001mr-NX for ged-emacs-devel@m.gmane.org; Thu, 04 Jul 2013 02:24:53 +0200 Original-Received: from localhost ([::1]:40014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuXLx-0006an-A8 for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2013 20:24:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuXLt-0006aW-Fq for emacs-devel@gnu.org; Wed, 03 Jul 2013 20:24:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuXLs-00088W-L6 for emacs-devel@gnu.org; Wed, 03 Jul 2013 20:24:49 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:39855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuXLs-00088S-I2 for emacs-devel@gnu.org; Wed, 03 Jul 2013 20:24:48 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r640OjVv015184; Wed, 3 Jul 2013 20:24:46 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 15A6EAE15B; Wed, 3 Jul 2013 20:24:45 -0400 (EDT) In-Reply-To: <8761x1f6e1.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 26 Jun 2013 13:39:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4628=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4628> : streams <993621> : uri <1466229> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161497 Archived-At: > It seem `lisp-completion-at-point' is no more returning :predicate, > (accessible in emacs-24.3 with (plist-get plist :predicate)) > is it wanted? It sometimes does, sometimes doesn't. Do you see a difference in the resulting behavior? > In `lisp--local-variables' e.g &optional is returned, is it wanted? No. > otherwise, the patch below fix it: > diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el > index b37a811..af8433a 100644 > --- a/lisp/emacs-lisp/lisp.el > +++ b/lisp/emacs-lisp/lisp.el > @@ -725,7 +725,7 @@ considered." > (delq nil > (mapcar (lambda (var) > (and (symbolp var) > - (not (string-match (symbol-name var) "\\`[&_]")) > + (not (string-match "\\`[&_]" (symbol-name var))) > ;; Eliminate uninterned vars. > (intern-soft var) > var)) Very much so, indeed, thanks for catching this typo. Feel free to install that patch, Stefan