From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: lisp-completion question
Date: Wed, 03 Jul 2013 20:24:45 -0400 [thread overview]
Message-ID: <jwvmwq3w4vf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8761x1f6e1.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 26 Jun 2013 13:39:18 +0200")
> It seem `lisp-completion-at-point' is no more returning :predicate,
> (accessible in emacs-24.3 with (plist-get plist :predicate))
> is it wanted?
It sometimes does, sometimes doesn't. Do you see a difference in the
resulting behavior?
> In `lisp--local-variables' e.g &optional is returned, is it wanted?
No.
> otherwise, the patch below fix it:
> diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el
> index b37a811..af8433a 100644
> --- a/lisp/emacs-lisp/lisp.el
> +++ b/lisp/emacs-lisp/lisp.el
> @@ -725,7 +725,7 @@ considered."
> (delq nil
> (mapcar (lambda (var)
> (and (symbolp var)
> - (not (string-match (symbol-name var) "\\`[&_]"))
> + (not (string-match "\\`[&_]" (symbol-name var)))
> ;; Eliminate uninterned vars.
> (intern-soft var)
> var))
Very much so, indeed, thanks for catching this typo. Feel free to
install that patch,
Stefan
next prev parent reply other threads:[~2013-07-04 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 11:39 lisp-completion question Thierry Volpiatto
2013-07-04 0:24 ` Stefan Monnier [this message]
2013-07-04 6:04 ` Thierry Volpiatto
2013-07-04 9:58 ` Stefan Monnier
2013-07-04 11:11 ` Thierry Volpiatto
2013-07-04 11:18 ` Thierry Volpiatto
2013-07-04 18:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwq3w4vf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).