From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Wed, 04 Feb 2015 16:58:57 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423087181 5282 80.91.229.3 (4 Feb 2015 21:59:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 21:59:41 +0000 (UTC) Cc: emacs-devel To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 22:59:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJ7z1-0003BC-UZ for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 22:59:40 +0100 Original-Received: from localhost ([::1]:39042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ7z1-0002ES-Dz for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 16:59:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ7yo-0002E5-GN for emacs-devel@gnu.org; Wed, 04 Feb 2015 16:59:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ7yl-0003qd-Ay for emacs-devel@gnu.org; Wed, 04 Feb 2015 16:59:26 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:53798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ7yl-0003qZ-6T for emacs-devel@gnu.org; Wed, 04 Feb 2015 16:59:23 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id C191485ECF; Wed, 4 Feb 2015 16:59:22 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 5592F1E5874; Wed, 4 Feb 2015 16:58:58 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 11C69B4102; Wed, 4 Feb 2015 16:58:58 -0500 (EST) In-Reply-To: (Jackson Hamilton's message of "Wed, 4 Feb 2015 11:46:31 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182408 Archived-At: > js2-mode is included in the repo for development and CI purposes. I want to > test in a clean environment (emacs -Q) and also on Travis CI. Having that > file available lets me easily add it to the load path. I do exclude it in > .elpaignore, because I expect that when context-coloring is installed, the > package manager will handle the dependency instead. Ah, right, that makes sense. > Yes, it is a truer statement that (in its current state) context-coloring > works fine for some modes, but requires those files for non-js2-mode > JavaScript modes. > esprima.js is sourced from here: > https://github.com/jquery/esprima/blob/1114c32c4e0ffaf47864967a835fdc0a37909f14/esprima.js > escope.js is sourced from here: > https://github.com/estools/escope/blob/b191ec36b744f65df094c614510ca6125284a958/escope.js > extraverse.js is sourced from here: > https://github.com/estools/estraverse/blob/c280df4aa75d7846328aa436ee5acd04afafc543/estraverse.js As long as we only redistribute these files without modifying them at all, I think it's fine to have them as-is in elpa.git. If I were you, I'd probably prefer to split them into a separate "javascript support for context-coloring" package, but luckily I'm not you, so feel free to do as you wish in this regard. Stefan