From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] scratch/package-fix e5d5cdf 1/2: emacs-lisp/package.el: Indicate incompatible packages.
Date: Thu, 12 Feb 2015 09:41:01 -0500 [thread overview]
Message-ID: <jwvmw4jjiyo.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <CAAdUY-KVVnp0ZQKpMSfyYiU6wd6VixKXWTjnJU51+ucY7U6c5Q@mail.gmail.com> (Artur Malabarba's message of "Wed, 11 Feb 2015 23:00:24 +0000")
>> > + ((not (package--compatible-p pkg-desc)) "incompat")
>> Of course, this should be transitive: if one of the required packages is
>> "incompat", then the package is also "incompat".
> Ideally, yes. That's why I factored it out as a function.
> However, this is called on each package about to be printed, and checking
> whether the dependencies are available imposes a performance cost that I'm
> not sure we should pay. The time for printing the package list will go from
> linear to quadratic in the number of packages.
I understand, I was just pointing out that this current solution
is incomplete. I expect that it's sufficient for now.
The algorithmic problem is quite real, indeed.
We could solve it by adding a "compatible" field to the struct, which
we'd set to `yes' or `no' (so as to memoize previous computations), so
the complexity would stay linear in the number of packages (though also
linear in the number of number of `requires').
Stefan
next prev parent reply other threads:[~2015-02-12 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150211170820.10979.16862@vcs.savannah.gnu.org>
[not found] ` <E1YLalx-0002s8-E8@vcs.savannah.gnu.org>
2015-02-11 19:28 ` [Emacs-diffs] scratch/package-fix e5d5cdf 1/2: emacs-lisp/package.el: Indicate incompatible packages Stefan Monnier
2015-02-11 23:00 ` Artur Malabarba
2015-02-12 14:41 ` Stefan Monnier [this message]
2015-02-12 16:35 ` Davis Herring
2015-02-13 13:48 ` Artur Malabarba
2015-02-12 21:42 ` chad
2015-02-13 20:13 ` Stefan Monnier
2015-02-13 20:18 ` Artur Malabarba
2015-02-14 18:04 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmw4jjiyo.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).