From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay Date: Mon, 05 Oct 2015 11:50:03 -0400 Message-ID: References: <20150930193450.11644.62040@vcs.savannah.gnu.org> <831tdd75i3.fsf@gnu.org> <83eghd5ff2.fsf@gnu.org> <83vbap3qxb.fsf@gnu.org> <83r3lc4du9.fsf@gnu.org> <83mvvz0xkh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444060225 17779 80.91.229.3 (5 Oct 2015 15:50:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2015 15:50:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 05 17:50:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zj81n-000706-Vz for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 17:50:16 +0200 Original-Received: from localhost ([::1]:46349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj81n-0006VO-2a for ged-emacs-devel@m.gmane.org; Mon, 05 Oct 2015 11:50:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj81j-0006VB-Ba for emacs-devel@gnu.org; Mon, 05 Oct 2015 11:50:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj81i-0004lb-IL for emacs-devel@gnu.org; Mon, 05 Oct 2015 11:50:11 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:18927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj81c-0004a3-US; Mon, 05 Oct 2015 11:50:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/3aQs2tcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZ8Xg2uSAiOCO4FZIoJ4AQEB X-IPAS-Result: A0CXDQA731xV/3aQs2tcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCws0EhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBZ8Xg2uSAiOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="167561558" Original-Received: from 107-179-144-118.cpe.teksavvy.com (HELO pastel.home) ([107.179.144.118]) by ironport2-out.teksavvy.com with ESMTP; 05 Oct 2015 11:50:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E51E46283A; Mon, 5 Oct 2015 11:50:03 -0400 (EDT) In-Reply-To: <83mvvz0xkh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Oct 2015 12:53:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190938 Archived-At: > I like it very much, thanks! Please commit. Thanks, installed. > Bonus points for adding something that describes where these variables > and the corresponding 'redisplay' flags are checked, because the > FOR_EACH_FRAME loop in redisplay_internal doesn't look at the > 'redisplay' flags, so a large part of the logic you describe above > isn't (easily) visible at that level. I added a note about the fact that the frame's redisplay flag is not sufficient to exclude a frame. Fundamentally, the only redisplay flags needed are the window ones. The frame and buffer's redisplay flags could be dispensed with, at the cost of making [bf]set_redisplay more expensive since they'd have to loop through all the windows of that frame/buffer. Stefan