From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Code reviews Date: Tue, 08 Mar 2016 08:27:41 -0500 Message-ID: References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <878u1tuzgn.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457443692 23844 80.91.229.3 (8 Mar 2016 13:28:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 13:28:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 14:28:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adHg9-0001Ik-M8 for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 14:28:01 +0100 Original-Received: from localhost ([::1]:34629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adHg8-0008N9-VR for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 08:28:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adHfu-0008Mo-5R for emacs-devel@gnu.org; Tue, 08 Mar 2016 08:27:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adHfq-0006L2-VF for emacs-devel@gnu.org; Tue, 08 Mar 2016 08:27:46 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:54845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adHfq-0006Ky-Qm for emacs-devel@gnu.org; Tue, 08 Mar 2016 08:27:42 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A9FgA731xV/30PNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIxALNBIUGA2IWwjPIwEBAQEGAQEBAR6LOoE9AYNHB4QtBYZhhU+hEodCI4IXgX8ggngBAQE X-IPAS-Result: A0A9FgA731xV/30PNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwFWIxALNBIUGA2IWwjPIwEBAQEGAQEBAR6LOoE9AYNHB4QtBYZhhU+hEodCI4IXgX8ggngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="195541411" Original-Received: from 157-52-15-125.cpe.teksavvy.com (HELO pastel.home) ([157.52.15.125]) by ironport2-out.teksavvy.com with ESMTP; 08 Mar 2016 08:27:42 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 00BE964149; Tue, 8 Mar 2016 08:27:41 -0500 (EST) In-Reply-To: <878u1tuzgn.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 08 Mar 2016 08:48:56 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201140 Archived-At: >> Maybe we could have a half-way system, where commits are pushed to >> a branch that is "not fast-forward-only", and this branch is then >> auto-merged to the real (fast-forward-only) master branch after a delay >> (one day, maybe?) to give time to fix mess ups before they're cast >> in stone. > I think that this would require some considerable co-ordination. If I > push a broken commit to devel branch, and then you fix this commit > through rebase, my copy of the branch (and everyone elses) is now > broken. I'm pretty sure that this kind of fix up can only happen on a > feature branch in a sane way. I think you misunderstood me: what I was thinking about in the quoted text is a system where you submit a pull request to a review queue (not to some kind of shared "proto-master" branch), and those requests are automatically accepted after some timeout. Stefan