From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 43cc5d8: Make `q' etc work in image mode again Date: Sun, 24 Apr 2016 10:59:26 -0400 Message-ID: References: <20160424142240.28121.22307@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461509985 30007 80.91.229.3 (24 Apr 2016 14:59:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 14:59:45 +0000 (UTC) Cc: Lars Magne Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 16:59:36 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auLVX-0002Za-9y for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 16:59:35 +0200 Original-Received: from localhost ([::1]:55679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLVW-0005QA-PZ for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 10:59:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLVT-0005Oi-OO for emacs-devel@gnu.org; Sun, 24 Apr 2016 10:59:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auLVQ-0005HO-JG for emacs-devel@gnu.org; Sun, 24 Apr 2016 10:59:31 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:38126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLVQ-0005HK-Dq for emacs-devel@gnu.org; Sun, 24 Apr 2016 10:59:28 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.7) with ESMTP id u3OEx3G8017774; Sun, 24 Apr 2016 10:59:03 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C0044AE971; Sun, 24 Apr 2016 10:59:26 -0400 (EDT) In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 24 Apr 2016 14:22:40 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5652=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5652> : inlines <4712> : streams <1624576> : uri <2195517> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203257 Archived-At: > - (let ((map (make-sparse-keymap))) > + (let ((map (copy-keymap image-map))) > (set-keymap-parent map special-mode-map) > - (set-keymap-parent map image-map) We should avoid using copy-keymap. If you want multiple-inheritance, we have it now: use make-composed-keymap. Stefan