Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert

[Stefan Monnier <monnier@iro.umontreal.ca>]

> Oh, I see; it would be helpful if you had included the rational in the
> commit message where you introduced it.

Indeed.

>> > Doing this causes problems when running ert tests
>> Can it be fixed somewhere else?
> I don't quite understand what's the benefit of calling debug when
> debug-on-error is non-nil: signalling the error is going to call it
> anyway.

Not if the code is run within an `ignore-errors` clause or some other
condition-case catching `error`.

> But it looks like funcalling `debugger' instead of calling `debug'
> seems to work:
> (defun cl--assertion-failed (form &optional string sargs args)
>   (if debug-on-error
>       (funcall debugger `(cl-assertion-failed ,form ,string ,@sargs))

Works for me.


        Stefan