From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make purecopy create hash tables properly Date: Sun, 29 Jan 2017 14:41:47 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485718934 3094 195.159.176.226 (29 Jan 2017 19:42:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 19:42:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 29 20:42:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXvMT-0000S8-V8 for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 20:42:06 +0100 Original-Received: from localhost ([::1]:56499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXvMZ-00030G-Ft for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 14:42:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXvMN-00030A-Kf for emacs-devel@gnu.org; Sun, 29 Jan 2017 14:42:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXvMJ-00069Y-PA for emacs-devel@gnu.org; Sun, 29 Jan 2017 14:41:59 -0500 Original-Received: from [195.159.176.226] (port=35326 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXvMJ-00069C-If for emacs-devel@gnu.org; Sun, 29 Jan 2017 14:41:55 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cXvMB-0008IU-1E for emacs-devel@gnu.org; Sun, 29 Jan 2017 20:41:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hGTYQex1m/FCo5GtUZ+t97B/w30= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211733 Archived-At: > Nitpick: I'd call it `purecopy_hash_table`. > > Other functions in alloc.c that perform pure allocation for different > objects are named in the same way (make_pure_string, > make_pure_vector), so I merely followed this convention. But those make pure objects "out of thin air", whereas in the present case what we do is to copy a pre-existing Lisp_Object into pure space. But, yes, you're right that the distinction is largely irrelevant, so either way is fine, Stefan