From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569)
Date: Tue, 18 Jul 2017 13:28:18 -0400 [thread overview]
Message-ID: <jwvmv81r6z6.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CAM-tV-_Txq8eADJnEkjN3+GFNTs5j9gHV=ANntFXAKL-qcrCgw@mail.gmail.com
>>> + ;; Update `this-command' and run `pre-command-hook' so that
>>> + ;; things like `delete-selection-pre-hook' will work correctly.
>>> + (setq this-command cmd)
>>> + (run-hooks 'pre-command-hook)
>>> ;; mouse-major-mode-menu was using `command-execute' instead.
>>> (call-interactively cmd))))
>>
>> Hmm... shouldn't it then also run post-command-hook, and set
>> last-command (and probably a few more of the things done in the usual
>> command loop, such as handling undo-boundaries)?
> I'm not sure, won't we end up with 1 1/2 of the command stuff done in
> that case? (the half being the popup-menu we began executing to get
> here).
AFAICT the current case is the one that ends up with 1½ done.
What I suggest is to bring it back to a whole number (i.e. 2).
Stefan
next prev parent reply other threads:[~2017-07-18 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170718103950.22436.83344@vcs0.savannah.gnu.org>
[not found] ` <20170718103952.4E6F720E35@vcs0.savannah.gnu.org>
2017-07-18 13:41 ` [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Stefan Monnier
2017-07-18 16:23 ` Noam Postavsky
2017-07-18 17:28 ` Stefan Monnier [this message]
2017-07-18 17:50 ` Noam Postavsky
2017-07-18 18:14 ` Stefan Monnier
2017-07-18 22:45 ` Noam Postavsky
2017-07-19 3:05 ` Stefan Monnier
2017-07-19 3:18 ` Tak Kunihiro
2017-07-19 11:26 ` Noam Postavsky
2017-07-20 0:14 ` Tak Kunihiro
2017-07-20 0:28 ` Noam Postavsky
2017-07-21 4:11 ` Tak Kunihiro
2017-07-20 1:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmv81r6z6.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).