From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name' Date: Sat, 05 Aug 2017 08:51:28 -0400 Message-ID: References: <20170805095359.14455.50578@vcs0.savannah.gnu.org> <20170805095400.0316E20660@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501937533 17878 195.159.176.226 (5 Aug 2017 12:52:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Aug 2017 12:52:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 05 14:52:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddyYm-0004FI-HE for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 14:52:04 +0200 Original-Received: from localhost ([::1]:56720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddyYs-0004Gf-Qk for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2017 08:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddyYI-0004GO-LD for emacs-devel@gnu.org; Sat, 05 Aug 2017 08:51:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddyYF-0001ib-KV for emacs-devel@gnu.org; Sat, 05 Aug 2017 08:51:34 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:51705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddyYF-0001fa-EP; Sat, 05 Aug 2017 08:51:31 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v75CpSum023568; Sat, 5 Aug 2017 08:51:28 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 59012661C0; Sat, 5 Aug 2017 08:51:28 -0400 (EDT) In-Reply-To: <20170805095400.0316E20660@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 5 Aug 2017 05:53:59 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.3 X-NAI-Spam-Rules: 4 Rules triggered UC_NAME=0.2, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6087=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6087> : inlines <6010> : streams <1757270> : uri <2476841> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217313 Archived-At: > - if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name))) > + if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore))) > + || NILP (Fget_buffer (name))) Why not just use Fequal instead of Fstring_equal? Stefan