unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name'
Date: Sat, 05 Aug 2017 08:51:28 -0400	[thread overview]
Message-ID: <jwvmv7e41qm.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170805095400.0316E20660@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Sat,  5 Aug 2017 05:53:59 -0400 (EDT)")

> -  if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name)))
> +  if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore)))
> +      || NILP (Fget_buffer (name)))

Why not just use Fequal instead of Fstring_equal?


        Stefan



       reply	other threads:[~2017-08-05 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170805095359.14455.50578@vcs0.savannah.gnu.org>
     [not found] ` <20170805095400.0316E20660@vcs0.savannah.gnu.org>
2017-08-05 12:51   ` Stefan Monnier [this message]
2017-08-05 13:02     ` [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name' Eli Zaretskii
2017-08-05 15:14       ` Stefan Monnier
2017-08-05 15:58         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmv7e41qm.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).