From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces
Date: Sun, 01 Oct 2017 23:14:53 -0400 [thread overview]
Message-ID: <jwvmv5aqm1w.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87tvzigzd3.fsf@lolita
>>> * lisp/emacs-lisp/bytecomp.el
>>> (byte-compile-log-warning-function): New variable.
>>> (byte-compile-log-warning): Use it.
>>> (byte-compile--log-warning-for-byte-compile): New function.
>> Looking at it, I think it'd be more useful to add
>> a `display-warning-function` which applies to all calls to
>> display-warning.
> OTOH, we're not exactly "displaying" a warning, we're collecting one.
I'm just pointing out that moving the hook from byte-compile-log-warning
to display-warning would make it more generally useful.
> No problem. As I think I said in the commit message these two "proper"
> interfaces are just pure boilerplate. Feel free to change them.
I think for checkdoc, the hook looks good enough.
Stefan
prev parent reply other threads:[~2017-10-02 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171001123811.5647.26035@vcs0.savannah.gnu.org>
[not found] ` <20171001123812.A22F12068C@vcs0.savannah.gnu.org>
2017-10-01 21:40 ` [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces Stefan Monnier
2017-10-02 0:36 ` João Távora
2017-10-02 3:14 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmv5aqm1w.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).