From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix battery information on FreeBSD Date: Mon, 11 Mar 2019 22:48:01 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167366"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 03:48:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3XTF-000hOW-Id for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2019 03:48:49 +0100 Original-Received: from localhost ([127.0.0.1]:43987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3XTE-0004OV-Jj for ged-emacs-devel@m.gmane.org; Mon, 11 Mar 2019 22:48:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3XSe-0004OO-8z for emacs-devel@gnu.org; Mon, 11 Mar 2019 22:48:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3XSd-0008VT-BP for emacs-devel@gnu.org; Mon, 11 Mar 2019 22:48:12 -0400 Original-Received: from [195.159.176.226] (port=56954 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3XSd-0008Tv-1b for emacs-devel@gnu.org; Mon, 11 Mar 2019 22:48:11 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h3XSa-000giH-Ux for emacs-devel@gnu.org; Tue, 12 Mar 2019 03:48:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:SGliIjPnF38iEXyWBeaZaU6Tz/k= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234087 Archived-At: > (let* ((os-name (car (split-string > (shell-command-to-string "/usr/bin/uname")))) > - (apm-flag (if (equal os-name "OpenBSD") "P" "s")) > - (apm-cmd (concat "/usr/sbin/apm -ablm" apm-flag)) > + (apm-flag (if (equal os-name "OpenBSD") "Pm")) > + (apm-flag (if (equal os-name "NetBSD") "sm")) > + (apm-flag (if (equal os-name "FreeBSD") "st")) This can't be right: with the above apm-flag will be nil except on FreeBSD (since the last apm-flag hides the previous ones). You probably want (apm-flag (pcase os-name ("OpenBSD" "Pm") ("FreeBSD" "st") (_ "sm"))) instead. Stefan