From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames Date: Sun, 28 Apr 2019 21:50:21 -0400 Message-ID: References: <20190427033619.18077.55804@vcs0.savannah.gnu.org> <20190427033621.4934B206A2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102169"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alexander Gramiak To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 29 03:50:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKvRB-000QSX-3e for ged-emacs-devel@m.gmane.org; Mon, 29 Apr 2019 03:50:33 +0200 Original-Received: from localhost ([127.0.0.1]:50629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKvRA-0003JP-1l for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 21:50:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKvR3-0003H3-8Q for emacs-devel@gnu.org; Sun, 28 Apr 2019 21:50:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKvR2-0000xY-Dj for emacs-devel@gnu.org; Sun, 28 Apr 2019 21:50:25 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKvR2-0000wt-0D for emacs-devel@gnu.org; Sun, 28 Apr 2019 21:50:24 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3T1oLpK007757; Sun, 28 Apr 2019 21:50:22 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 707D56619A; Sun, 28 Apr 2019 21:50:21 -0400 (EDT) In-Reply-To: <20190427033621.4934B206A2@vcs0.savannah.gnu.org> (Alexander Gramiak's message of "Fri, 26 Apr 2019 23:36:20 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6534=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6534> : inlines <7062> : streams <1820024> : uri <2838290> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236021 Archived-At: > - if (FRAME_RIF (f)->clear_under_internal_border) > + if (FRAME_WINDOW_P (f) > + && FRAME_RIF (f)->clear_under_internal_border) Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make more sense? At least, it would not rely on the fact that FRAME_RIF(f) is supposedly non-NULL when FRAME_WINDOW_P(f) is true. It'd make the code more "obviously safe". Stefan